Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Side by Side Diff: tools/perf/profile_creators/profile_extender.py

Issue 1020703002: Telemetry: Remove the class ProfileCreator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 class ProfileCreator(object): 5 class ProfileExtender(object):
6 """Abstract base class for an object that constructs a Chrome profile.""" 6 """Abstract base class for an object that constructs a Chrome profile."""
7 7
8 def Run(self, options): 8 def Run(self, options):
9 """Creates the profile. 9 """Creates or extends the profile.
10 10
11 |options| is an instance of BrowserFinderOptions. When subclass 11 |options| is an instance of BrowserFinderOptions. When subclass
12 implementations of this method inevitably attempt to find and launch a 12 implementations of this method inevitably attempt to find and launch a
13 browser, they should pass |options| to the relevant methods. 13 browser, they should pass |options| to the relevant methods.
14 14
15 Several properties of |options| might require direct manipulation by 15 Several properties of |options| might require direct manipulation by
16 subclasses. These are: 16 subclasses. These are:
17 |options.output_profile_path|: The path at which the profile should be 17 |options.output_profile_path|: The path at which the profile should be
18 created. 18 created.
19 |options.browser_options.profile_dir|: If this property is None, then a 19 |options.browser_options.profile_dir|: If this property is None, then a
20 new profile is created. Otherwise, the existing profile is appended on 20 new profile is created. Otherwise, the existing profile is appended on
21 to. 21 to.
22 """ 22 """
23 raise NotImplementedError() 23 raise NotImplementedError()
OLDNEW
« no previous file with comments | « tools/perf/profile_creators/profile_creator.py ('k') | tools/perf/profile_creators/profile_generator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698