Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1020213002: Componentize conversion of content::FaviconURL to favicon::FaviconURL (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 9 months ago
Reviewers:
jif, Avi (use Gerrit), Nico
CC:
chromium-reviews, jam, browser-components-watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@browser
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize conversion of content::FaviconURL to favicon::FaviconURL In preparation of componentization of FaviconTabHelper, introduce a new target //components/favicon/content (as favicon is a layered component) and move the function to convert from content::FaviconURL to favicon::FaviconURL there. BUG=374281 Committed: https://crrev.com/001b10dec2850df49383baaaf2c401125b10abda Cr-Commit-Position: refs/heads/master@{#321606}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -32 lines) Patch
M chrome/browser/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 2 chunks +3 lines, -27 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/favicon.gypi View 1 chunk +25 lines, -0 lines 0 comments Download
A + components/favicon/content/BUILD.gn View 1 chunk +6 lines, -5 lines 0 comments Download
A + components/favicon/content/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A components/favicon/content/favicon_url_util.h View 1 chunk +28 lines, -0 lines 0 comments Download
A components/favicon/content/favicon_url_util.cc View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sdefresne
jif: please take a look thakis: OWNERS for chrome/browser/BUILD.gn avi: OWNERS for new dependency on ...
5 years, 9 months ago (2015-03-20 13:25:04 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 9 months ago (2015-03-20 13:51:53 UTC) #3
jif
lgtm
5 years, 9 months ago (2015-03-20 14:08:01 UTC) #4
Nico
lgtm
5 years, 9 months ago (2015-03-20 14:36:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1020213002/1
5 years, 9 months ago (2015-03-20 17:07:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 18:41:56 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 18:46:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/001b10dec2850df49383baaaf2c401125b10abda
Cr-Commit-Position: refs/heads/master@{#321606}

Powered by Google App Engine
This is Rietveld 408576698