Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Unified Diff: components/favicon.gypi

Issue 1020213002: Componentize conversion of content::FaviconURL to favicon::FaviconURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browser
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | components/favicon/content/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/favicon.gypi
diff --git a/components/favicon.gypi b/components/favicon.gypi
index d5b3e9cb84563fcb1af83c463e7de69e3c68bc61..be91eeba3cee402993e39b43527c45497174b566 100644
--- a/components/favicon.gypi
+++ b/components/favicon.gypi
@@ -34,4 +34,29 @@
],
},
],
+ 'conditions': [
+ ['OS!="ios"', {
+ 'targets': [
+ {
+ # GN version: //components/favicon/content
+ 'target_name': 'favicon_content',
+ 'type': 'static_library',
+ 'dependencies': [
+ '../content/content.gyp:content_browser',
+ '../content/content.gyp:content_common',
+ 'favicon_base',
+ 'favicon_core',
+ ],
+ 'sources': [
+ # Note: sources list duplicated in GN build.
+ 'favicon/content/favicon_url_util.h',
+ 'favicon/content/favicon_url_util.cc',
+ ],
+ 'include_dirs': [
+ '..',
+ ],
+ },
+ ],
+ }],
+ ],
}
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | components/favicon/content/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698