Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: components/favicon.gypi

Issue 1020213002: Componentize conversion of content::FaviconURL to favicon::FaviconURL (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@browser
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | components/favicon/content/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # GN version: //components/favicon/core 8 # GN version: //components/favicon/core
9 'target_name': 'favicon_core', 9 'target_name': 'favicon_core',
10 'type': 'static_library', 10 'type': 'static_library',
(...skipping 16 matching lines...) Expand all
27 'favicon/core/favicon_service.h', 27 'favicon/core/favicon_service.h',
28 'favicon/core/favicon_tab_helper_observer.h', 28 'favicon/core/favicon_tab_helper_observer.h',
29 'favicon/core/favicon_url.cc', 29 'favicon/core/favicon_url.cc',
30 'favicon/core/favicon_url.h', 30 'favicon/core/favicon_url.h',
31 ], 31 ],
32 'include_dirs': [ 32 'include_dirs': [
33 '..', 33 '..',
34 ], 34 ],
35 }, 35 },
36 ], 36 ],
37 'conditions': [
38 ['OS!="ios"', {
39 'targets': [
40 {
41 # GN version: //components/favicon/content
42 'target_name': 'favicon_content',
43 'type': 'static_library',
44 'dependencies': [
45 '../content/content.gyp:content_browser',
46 '../content/content.gyp:content_common',
47 'favicon_base',
48 'favicon_core',
49 ],
50 'sources': [
51 # Note: sources list duplicated in GN build.
52 'favicon/content/favicon_url_util.h',
53 'favicon/content/favicon_url_util.cc',
54 ],
55 'include_dirs': [
56 '..',
57 ],
58 },
59 ],
60 }],
61 ],
37 } 62 }
OLDNEW
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | components/favicon/content/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698