Remove uniqueID from all filter serialization.

Remove uniqueID from all filter serialization.

(This is essentially a revert of https://codereview.chromium.org/503833002/.)

This was necessary back when SkPaint was flattened even for in-process use. Now that we only flatten SkPaint for cross-process use, there's no need to serialize UniqueIDs.

Note: SkDropShadowImageFilter is being constructed with a croprect and UniqueID (of 0) in Blink. I've made the uniqueID param default to 0 temporarily, until this rolls in and Blink can be changed. (Blink can't be changed first, since unlike the other filters, there's no constructor that takes a cropRect but not a uniqueID.)

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/24e06d5244ae96e440410e1d76e039983b2efac9

[Stephen White, 2015-03-18 14:34:17]

senorblanco@chromium.org changed reviewers:
+ reed@google.com

[Stephen White, 2015-03-18 14:34:25]

PTAL. Thanks!

[reed1, 2015-03-18 15:01:05]

reed@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips, 2015-03-18 16:51:43]

This doesn't seem to actually alter the serialization.

https://codereview.chromium.org/1019493002/diff/80001/src/effects/SkLightingI...
File src/effects/SkLightingImageFilter.cpp (right):

https://codereview.chromium.org/1019493002/diff/80001/src/effects/SkLightingI...
src/effects/SkLightingImageFilter.cpp:963:
SkDiffuseLightingImageFilter::SkDiffuseLightingImageFilter(SkLight* light,
SkScalar surfaceScale, SkScalar kd, SkImageFilter* input, const CropRect*
cropRect = NULL)
Why add this "= NULL" here ?

https://codereview.chromium.org/1019493002/diff/80001/src/effects/SkMergeImag...
File src/effects/SkMergeImageFilter.cpp (right):

https://codereview.chromium.org/1019493002/diff/80001/src/effects/SkMergeImag...
src/effects/SkMergeImageFilter.cpp:44: const SkXfermode::Mode modes[],
overlength ?

[Stephen White, 2015-03-18 16:55:29]

Thanks for your review.

You're right; this doesn't change the serialization. That'll
be removed in a different change.

https://codereview.chromium.org/1019493002/diff/80001/src/effects/SkLightingI...
File src/effects/SkLightingImageFilter.cpp (right):

https://codereview.chromium.org/1019493002/diff/80001/src/effects/SkLightingI...
src/effects/SkLightingImageFilter.cpp:963:
SkDiffuseLightingImageFilter::SkDiffuseLightingImageFilter(SkLight* light,
SkScalar surfaceScale, SkScalar kd, SkImageFilter* input, const CropRect*
cropRect = NULL)
On 2015/03/18 16:51:43, robertphillips wrote:
> Why add this "= NULL" here ?

Bad revert. Fixed.

https://codereview.chromium.org/1019493002/diff/80001/src/effects/SkMergeImag...
File src/effects/SkMergeImageFilter.cpp (right):

https://codereview.chromium.org/1019493002/diff/80001/src/effects/SkMergeImag...
src/effects/SkMergeImageFilter.cpp:44: const SkXfermode::Mode modes[],
On 2015/03/18 16:51:43, robertphillips wrote:
> overlength ?

Fixed.

[robertphillips, 2015-03-18 17:08:13]

lgtm but I would (perhaps quixotically) still like a VC to understand what's
going on at a deeper level

[Stephen White, 2015-03-18 17:47:05]

OK, new patch up which nulls out serialization/deserialzation of uniqueID.

[robertphillips, 2015-03-18 18:02:16]

lgtm but we probably do want a follow up that adds the  VXX_COMPATIBILITY_CODE
guards

[reed1, 2015-03-18 18:08:42]

lgtm

[Stephen White, 2015-03-18 19:01:57]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2015-03-18 19:05:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1019493002/120001

[commit-bot: I haz the power, 2015-03-18 19:11:37]

Committed patchset #7 (id:120001) as
https://skia.googlesource.com/skia/+/24e06d5244ae96e440410e1d76e039983b2efac9