Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: src/effects/SkMatrixConvolutionImageFilter.cpp

Issue 1019493002: Remove uniqueID from all filter serialization. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Null out fUniqueID deserialization Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/effects/SkLightingImageFilter.cpp ('k') | src/effects/SkMatrixImageFilter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The Android Open Source Project 2 * Copyright 2012 The Android Open Source Project
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkMatrixConvolutionImageFilter.h" 8 #include "SkMatrixConvolutionImageFilter.h"
9 #include "SkBitmap.h" 9 #include "SkBitmap.h"
10 #include "SkColorPriv.h" 10 #include "SkColorPriv.h"
(...skipping 12 matching lines...) Expand all
23 23
24 SkMatrixConvolutionImageFilter::SkMatrixConvolutionImageFilter( 24 SkMatrixConvolutionImageFilter::SkMatrixConvolutionImageFilter(
25 const SkISize& kernelSize, 25 const SkISize& kernelSize,
26 const SkScalar* kernel, 26 const SkScalar* kernel,
27 SkScalar gain, 27 SkScalar gain,
28 SkScalar bias, 28 SkScalar bias,
29 const SkIPoint& kernelOffset, 29 const SkIPoint& kernelOffset,
30 TileMode tileMode, 30 TileMode tileMode,
31 bool convolveAlpha, 31 bool convolveAlpha,
32 SkImageFilter* input, 32 SkImageFilter* input,
33 const CropRect* cropRect, 33 const CropRect* cropRect)
34 uint32_t uniqueID) 34 : INHERITED(1, &input, cropRect),
35 : INHERITED(1, &input, cropRect, uniqueID),
36 fKernelSize(kernelSize), 35 fKernelSize(kernelSize),
37 fGain(gain), 36 fGain(gain),
38 fBias(bias), 37 fBias(bias),
39 fKernelOffset(kernelOffset), 38 fKernelOffset(kernelOffset),
40 fTileMode(tileMode), 39 fTileMode(tileMode),
41 fConvolveAlpha(convolveAlpha) { 40 fConvolveAlpha(convolveAlpha) {
42 size_t size = (size_t) sk_64_mul(fKernelSize.width(), fKernelSize.height()); 41 size_t size = (size_t) sk_64_mul(fKernelSize.width(), fKernelSize.height());
43 fKernel = SkNEW_ARRAY(SkScalar, size); 42 fKernel = SkNEW_ARRAY(SkScalar, size);
44 memcpy(fKernel, kernel, size * sizeof(SkScalar)); 43 memcpy(fKernel, kernel, size * sizeof(SkScalar));
45 SkASSERT(kernelSize.fWidth >= 1 && kernelSize.fHeight >= 1); 44 SkASSERT(kernelSize.fWidth >= 1 && kernelSize.fHeight >= 1);
46 SkASSERT(kernelOffset.fX >= 0 && kernelOffset.fX < kernelSize.fWidth); 45 SkASSERT(kernelOffset.fX >= 0 && kernelOffset.fX < kernelSize.fWidth);
47 SkASSERT(kernelOffset.fY >= 0 && kernelOffset.fY < kernelSize.fHeight); 46 SkASSERT(kernelOffset.fY >= 0 && kernelOffset.fY < kernelSize.fHeight);
48 } 47 }
49 48
50 SkMatrixConvolutionImageFilter* SkMatrixConvolutionImageFilter::Create( 49 SkMatrixConvolutionImageFilter* SkMatrixConvolutionImageFilter::Create(
51 const SkISize& kernelSize, 50 const SkISize& kernelSize,
52 const SkScalar* kernel, 51 const SkScalar* kernel,
53 SkScalar gain, 52 SkScalar gain,
54 SkScalar bias, 53 SkScalar bias,
55 const SkIPoint& kernelOffset, 54 const SkIPoint& kernelOffset,
56 TileMode tileMode, 55 TileMode tileMode,
57 bool convolveAlpha, 56 bool convolveAlpha,
58 SkImageFilter* input, 57 SkImageFilter* input,
59 const CropRect* cropRect, 58 const CropRect* cropRect) {
60 uint32_t uniqueID) {
61 if (kernelSize.width() < 1 || kernelSize.height() < 1) { 59 if (kernelSize.width() < 1 || kernelSize.height() < 1) {
62 return NULL; 60 return NULL;
63 } 61 }
64 if (gMaxKernelSize / kernelSize.fWidth < kernelSize.fHeight) { 62 if (gMaxKernelSize / kernelSize.fWidth < kernelSize.fHeight) {
65 return NULL; 63 return NULL;
66 } 64 }
67 if (!kernel) { 65 if (!kernel) {
68 return NULL; 66 return NULL;
69 } 67 }
70 if ((kernelOffset.fX < 0) || (kernelOffset.fX >= kernelSize.fWidth) || 68 if ((kernelOffset.fX < 0) || (kernelOffset.fX >= kernelSize.fWidth) ||
71 (kernelOffset.fY < 0) || (kernelOffset.fY >= kernelSize.fHeight)) { 69 (kernelOffset.fY < 0) || (kernelOffset.fY >= kernelSize.fHeight)) {
72 return NULL; 70 return NULL;
73 } 71 }
74 return SkNEW_ARGS(SkMatrixConvolutionImageFilter, (kernelSize, kernel, gain, bias, 72 return SkNEW_ARGS(SkMatrixConvolutionImageFilter, (kernelSize, kernel, gain, bias,
75 kernelOffset, tileMode, c onvolveAlpha, 73 kernelOffset, tileMode, c onvolveAlpha,
76 input, cropRect, uniqueID )); 74 input, cropRect));
77 } 75 }
78 76
79 SkFlattenable* SkMatrixConvolutionImageFilter::CreateProc(SkReadBuffer& buffer) { 77 SkFlattenable* SkMatrixConvolutionImageFilter::CreateProc(SkReadBuffer& buffer) {
80 SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1); 78 SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 1);
81 SkISize kernelSize; 79 SkISize kernelSize;
82 kernelSize.fWidth = buffer.readInt(); 80 kernelSize.fWidth = buffer.readInt();
83 kernelSize.fHeight = buffer.readInt(); 81 kernelSize.fHeight = buffer.readInt();
84 const int count = buffer.getArrayCount(); 82 const int count = buffer.getArrayCount();
85 83
86 const int64_t kernelArea = sk_64_mul(kernelSize.width(), kernelSize.height() ); 84 const int64_t kernelArea = sk_64_mul(kernelSize.width(), kernelSize.height() );
87 if (!buffer.validate(kernelArea == count)) { 85 if (!buffer.validate(kernelArea == count)) {
88 return NULL; 86 return NULL;
89 } 87 }
90 SkAutoSTArray<16, SkScalar> kernel(count); 88 SkAutoSTArray<16, SkScalar> kernel(count);
91 if (!buffer.readScalarArray(kernel.get(), count)) { 89 if (!buffer.readScalarArray(kernel.get(), count)) {
92 return NULL; 90 return NULL;
93 } 91 }
94 SkScalar gain = buffer.readScalar(); 92 SkScalar gain = buffer.readScalar();
95 SkScalar bias = buffer.readScalar(); 93 SkScalar bias = buffer.readScalar();
96 SkIPoint kernelOffset; 94 SkIPoint kernelOffset;
97 kernelOffset.fX = buffer.readInt(); 95 kernelOffset.fX = buffer.readInt();
98 kernelOffset.fY = buffer.readInt(); 96 kernelOffset.fY = buffer.readInt();
99 TileMode tileMode = (TileMode)buffer.readInt(); 97 TileMode tileMode = (TileMode)buffer.readInt();
100 bool convolveAlpha = buffer.readBool(); 98 bool convolveAlpha = buffer.readBool();
101 return Create(kernelSize, kernel.get(), gain, bias, kernelOffset, tileMode, convolveAlpha, 99 return Create(kernelSize, kernel.get(), gain, bias, kernelOffset, tileMode, convolveAlpha,
102 common.getInput(0), &common.cropRect(), common.uniqueID()); 100 common.getInput(0), &common.cropRect());
103 } 101 }
104 102
105 void SkMatrixConvolutionImageFilter::flatten(SkWriteBuffer& buffer) const { 103 void SkMatrixConvolutionImageFilter::flatten(SkWriteBuffer& buffer) const {
106 this->INHERITED::flatten(buffer); 104 this->INHERITED::flatten(buffer);
107 buffer.writeInt(fKernelSize.fWidth); 105 buffer.writeInt(fKernelSize.fWidth);
108 buffer.writeInt(fKernelSize.fHeight); 106 buffer.writeInt(fKernelSize.fHeight);
109 buffer.writeScalarArray(fKernel, fKernelSize.fWidth * fKernelSize.fHeight); 107 buffer.writeScalarArray(fKernel, fKernelSize.fWidth * fKernelSize.fHeight);
110 buffer.writeScalar(fGain); 108 buffer.writeScalar(fGain);
111 buffer.writeScalar(fBias); 109 buffer.writeScalar(fBias);
112 buffer.writeInt(fKernelOffset.fX); 110 buffer.writeInt(fKernelOffset.fX);
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 str->appendf("%f ", fKernel[y * fKernelSize.width() + x]); 377 str->appendf("%f ", fKernel[y * fKernelSize.width() + x]);
380 } 378 }
381 } 379 }
382 str->appendf(")"); 380 str->appendf(")");
383 str->appendf("gain: %f bias: %f ", fGain, fBias); 381 str->appendf("gain: %f bias: %f ", fGain, fBias);
384 str->appendf("offset: (%d, %d) ", fKernelOffset.fX, fKernelOffset.fY); 382 str->appendf("offset: (%d, %d) ", fKernelOffset.fX, fKernelOffset.fY);
385 str->appendf("convolveAlpha: %s", fConvolveAlpha ? "true" : "false"); 383 str->appendf("convolveAlpha: %s", fConvolveAlpha ? "true" : "false");
386 str->append(")"); 384 str->append(")");
387 } 385 }
388 #endif 386 #endif
OLDNEW
« no previous file with comments | « src/effects/SkLightingImageFilter.cpp ('k') | src/effects/SkMatrixImageFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698