Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: src/effects/SkDisplacementMapEffect.cpp

Issue 1019493002: Remove uniqueID from all filter serialization. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Null out fUniqueID deserialization Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/effects/SkColorFilterImageFilter.cpp ('k') | src/effects/SkDropShadowImageFilter.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 Google Inc. 2 * Copyright 2013 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkDisplacementMapEffect.h" 8 #include "SkDisplacementMapEffect.h"
9 #include "SkReadBuffer.h" 9 #include "SkReadBuffer.h"
10 #include "SkWriteBuffer.h" 10 #include "SkWriteBuffer.h"
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 157
158 } // end namespace 158 } // end namespace
159 159
160 /////////////////////////////////////////////////////////////////////////////// 160 ///////////////////////////////////////////////////////////////////////////////
161 161
162 SkDisplacementMapEffect* SkDisplacementMapEffect::Create(ChannelSelectorType xCh annelSelector, 162 SkDisplacementMapEffect* SkDisplacementMapEffect::Create(ChannelSelectorType xCh annelSelector,
163 ChannelSelectorType yCh annelSelector, 163 ChannelSelectorType yCh annelSelector,
164 SkScalar scale, 164 SkScalar scale,
165 SkImageFilter* displace ment, 165 SkImageFilter* displace ment,
166 SkImageFilter* color, 166 SkImageFilter* color,
167 const CropRect* cropRec t, uint32_t uniqueID) { 167 const CropRect* cropRec t) {
168 if (!channel_selector_type_is_valid(xChannelSelector) || 168 if (!channel_selector_type_is_valid(xChannelSelector) ||
169 !channel_selector_type_is_valid(yChannelSelector)) { 169 !channel_selector_type_is_valid(yChannelSelector)) {
170 return NULL; 170 return NULL;
171 } 171 }
172 172
173 SkImageFilter* inputs[2] = { displacement, color }; 173 SkImageFilter* inputs[2] = { displacement, color };
174 return SkNEW_ARGS(SkDisplacementMapEffect, (xChannelSelector, yChannelSelect or, scale, 174 return SkNEW_ARGS(SkDisplacementMapEffect, (xChannelSelector, yChannelSelect or, scale,
175 inputs, cropRect, uniqueID)); 175 inputs, cropRect));
176 } 176 }
177 177
178 SkDisplacementMapEffect::SkDisplacementMapEffect(ChannelSelectorType xChannelSel ector, 178 SkDisplacementMapEffect::SkDisplacementMapEffect(ChannelSelectorType xChannelSel ector,
179 ChannelSelectorType yChannelSel ector, 179 ChannelSelectorType yChannelSel ector,
180 SkScalar scale, 180 SkScalar scale,
181 SkImageFilter* inputs[2], 181 SkImageFilter* inputs[2],
182 const CropRect* cropRect, 182 const CropRect* cropRect)
183 uint32_t uniqueID) 183 : INHERITED(2, inputs, cropRect)
184 : INHERITED(2, inputs, cropRect, uniqueID)
185 , fXChannelSelector(xChannelSelector) 184 , fXChannelSelector(xChannelSelector)
186 , fYChannelSelector(yChannelSelector) 185 , fYChannelSelector(yChannelSelector)
187 , fScale(scale) 186 , fScale(scale)
188 { 187 {
189 } 188 }
190 189
191 SkDisplacementMapEffect::~SkDisplacementMapEffect() { 190 SkDisplacementMapEffect::~SkDisplacementMapEffect() {
192 } 191 }
193 192
194 SkFlattenable* SkDisplacementMapEffect::CreateProc(SkReadBuffer& buffer) { 193 SkFlattenable* SkDisplacementMapEffect::CreateProc(SkReadBuffer& buffer) {
195 SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 2); 194 SK_IMAGEFILTER_UNFLATTEN_COMMON(common, 2);
196 ChannelSelectorType xsel = (ChannelSelectorType)buffer.readInt(); 195 ChannelSelectorType xsel = (ChannelSelectorType)buffer.readInt();
197 ChannelSelectorType ysel = (ChannelSelectorType)buffer.readInt(); 196 ChannelSelectorType ysel = (ChannelSelectorType)buffer.readInt();
198 SkScalar scale = buffer.readScalar(); 197 SkScalar scale = buffer.readScalar();
199 return Create(xsel, ysel, scale, common.getInput(0), common.getInput(1), &co mmon.cropRect(), common.uniqueID()); 198 return Create(xsel, ysel, scale, common.getInput(0), common.getInput(1), &co mmon.cropRect());
200 } 199 }
201 200
202 void SkDisplacementMapEffect::flatten(SkWriteBuffer& buffer) const { 201 void SkDisplacementMapEffect::flatten(SkWriteBuffer& buffer) const {
203 this->INHERITED::flatten(buffer); 202 this->INHERITED::flatten(buffer);
204 buffer.writeInt((int) fXChannelSelector); 203 buffer.writeInt((int) fXChannelSelector);
205 buffer.writeInt((int) fYChannelSelector); 204 buffer.writeInt((int) fYChannelSelector);
206 buffer.writeScalar(fScale); 205 buffer.writeScalar(fScale);
207 } 206 }
208 207
209 bool SkDisplacementMapEffect::onFilterImage(Proxy* proxy, 208 bool SkDisplacementMapEffect::onFilterImage(Proxy* proxy,
(...skipping 421 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 const GrGLCaps&, GrProcessorKeyBuilder* b ) { 630 const GrGLCaps&, GrProcessorKeyBuilder* b ) {
632 const GrDisplacementMapEffect& displacementMap = proc.cast<GrDisplacementMap Effect>(); 631 const GrDisplacementMapEffect& displacementMap = proc.cast<GrDisplacementMap Effect>();
633 632
634 uint32_t xKey = displacementMap.xChannelSelector(); 633 uint32_t xKey = displacementMap.xChannelSelector();
635 uint32_t yKey = displacementMap.yChannelSelector() << kChannelSelectorKeyBit s; 634 uint32_t yKey = displacementMap.yChannelSelector() << kChannelSelectorKeyBit s;
636 635
637 b->add32(xKey | yKey); 636 b->add32(xKey | yKey);
638 } 637 }
639 #endif 638 #endif
640 639
OLDNEW
« no previous file with comments | « src/effects/SkColorFilterImageFilter.cpp ('k') | src/effects/SkDropShadowImageFilter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698