Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1019443003: Remove the |style| parameter to InkWell (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
rafaelw, ojan
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove the |style| parameter to InkWell There's no reason for InkWell to take a |style| parameter anymore. Clients can simply use StyleNode instead. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/015b77b208ec36b04dcfc37861af6eede4b337ef

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -32 lines) Patch
M sky/examples/stocks-fn/lib/stock_row.dart View 2 chunks +1 line, -5 lines 0 comments Download
M sky/framework/components/ink_well.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M sky/framework/components/material.dart View 1 chunk +3 lines, -5 lines 2 comments Download
M sky/framework/components/menu_item.dart View 1 chunk +16 lines, -14 lines 0 comments Download
M sky/framework/components/radio.dart View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
5 years, 9 months ago (2015-03-25 05:09:08 UTC) #2
rafaelw
lgtm https://codereview.chromium.org/1019443003/diff/1/sky/framework/components/material.dart File sky/framework/components/material.dart (right): https://codereview.chromium.org/1019443003/diff/1/sky/framework/components/material.dart#newcode34 sky/framework/components/material.dart:34: level > 0 ? style.extend(shadowStyle[level]) : style); indent
5 years, 9 months ago (2015-03-25 16:56:01 UTC) #3
abarth-chromium
Committed patchset #1 (id:1) manually as 015b77b208ec36b04dcfc37861af6eede4b337ef (presubmit successful).
5 years, 9 months ago (2015-03-25 17:41:42 UTC) #4
abarth-chromium
5 years, 9 months ago (2015-03-25 17:43:53 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1019443003/diff/1/sky/framework/components/ma...
File sky/framework/components/material.dart (right):

https://codereview.chromium.org/1019443003/diff/1/sky/framework/components/ma...
sky/framework/components/material.dart:34: level > 0 ?
style.extend(shadowStyle[level]) : style);
On 2015/03/25 at 16:56:01, rafaelw wrote:
> indent

This gets removed in a later CL, so I'm going to land it with the bad indent for
now to avoid merge conflicts.

Powered by Google App Engine
This is Rietveld 408576698