Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: sky/framework/components/ink_well.dart

Issue 1019443003: Remove the |style| parameter to InkWell (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/framework/components/ink_well.dart
diff --git a/sky/framework/components/ink_well.dart b/sky/framework/components/ink_well.dart
index 6f452694f7b34e7bd6cfdf4f9637a0d2e43b3cd1..d7a8fc5e432f8b611f48e23414aabb7fb29d9c25 100644
--- a/sky/framework/components/ink_well.dart
+++ b/sky/framework/components/ink_well.dart
@@ -8,13 +8,15 @@ import 'dart:sky' as sky;
import 'ink_splash.dart';
class InkWell extends Component {
+ static final Style _containmentStyleHack = new Style('''
+ transform: translateX(0);''');
+
LinkedHashSet<SplashController> _splashes;
- Style style;
String inlineStyle;
List<Node> children;
- InkWell({ Object key, this.style, this.inlineStyle, this.children })
+ InkWell({ Object key, this.inlineStyle, this.children })
: super(key: key) {
onDidUnmount(() {
_cancelSplashes(null);
@@ -34,9 +36,9 @@ class InkWell extends Component {
return new EventTarget(
new Container(
- style: style,
- inlineStyle: inlineStyle,
- children: childrenIncludingSplashes),
+ style: _containmentStyleHack,
+ inlineStyle: inlineStyle,
+ children: childrenIncludingSplashes),
onGestureTapDown: _startSplash,
onGestureTap: _confirmSplash
);

Powered by Google App Engine
This is Rietveld 408576698