Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: sky/framework/components/menu_item.dart

Issue 1019443003: Remove the |style| parameter to InkWell (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/framework/components/menu_item.dart
diff --git a/sky/framework/components/menu_item.dart b/sky/framework/components/menu_item.dart
index 48a5d5fecdf28374f105692cc75f937785688795..05e80b9648898f97d6e8fcc14bb3da392cb01ff6 100644
--- a/sky/framework/components/menu_item.dart
+++ b/sky/framework/components/menu_item.dart
@@ -40,21 +40,23 @@ class MenuItem extends ButtonBase {
MenuItem({ Object key, this.icon, this.children }) : super(key: key);
Node buildContent() {
- return new InkWell (
- style: highlight ? _highlightStyle : _style,
- children: [
- new StyleNode(
- new Icon(
- size: 24,
- type: "${icon}_grey600"
+ return new StyleNode(
+ new InkWell(
+ children: [
+ new StyleNode(
+ new Icon(
+ size: 24,
+ type: "${icon}_grey600"
+ ),
+ _iconStyle
),
- _iconStyle
- ),
- new Container(
- style: _labelStyle,
- children: children
- )
- ]
+ new Container(
+ style: _labelStyle,
+ children: children
+ )
+ ]
+ ),
+ highlight ? _highlightStyle : _style
);
}
}

Powered by Google App Engine
This is Rietveld 408576698