Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1019243006: Tolerate weird cl_kernels modules (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Tolerate weird cl_kernels modules. cl_kernels modules (OpenCL kernels) are not structured as correct Mach-O images on Mac OS X 10.10, but they’re present frequently enough that it’s worth detecting and tolerating their quirks. As discussed in https://groups.google.com/a/chromium.org/d/msg/crashpad-dev/NaB7PrfW04g/FanqNJkVBfUJ Apple bug: https://openradar.appspot.com/20239912 TEST=crashpad_snapshot_test ProcessReader.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/5d0a133ecd6625f30c6491d502f12f26a0bef32d

Patch Set 1 #

Patch Set 2 : Add test #

Patch Set 3 : Fix 10.6 #

Patch Set 4 : #

Patch Set 5 : Disable optimization and call a built-in function #

Patch Set 6 : Reference https://openradar.appspot.com/20239912 #

Patch Set 7 : Check the Mach-O file type too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -9 lines) Patch
M snapshot/mac/mach_o_image_reader.h View 2 chunks +3 lines, -1 line 0 comments Download
M snapshot/mac/mach_o_image_reader.cc View 1 2 3 4 5 6 4 chunks +20 lines, -3 lines 0 comments Download
M snapshot/mac/mach_o_image_segment_reader.h View 1 2 3 4 5 6 1 chunk +8 lines, -1 line 0 comments Download
M snapshot/mac/mach_o_image_segment_reader.cc View 1 2 3 4 5 6 3 chunks +27 lines, -4 lines 0 comments Download
M snapshot/mac/process_reader_test.cc View 1 2 3 4 5 6 10 chunks +131 lines, -0 lines 0 comments Download
M snapshot/snapshot.gyp View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
Figuring out how to write the test wasn’t exactly how I had hoped to spend ...
5 years, 9 months ago (2015-03-19 21:56:04 UTC) #2
Robert Sesek
LGTM. Yeah this test is a bit black-boxy.
5 years, 9 months ago (2015-03-23 18:10:03 UTC) #3
Mark Mentovai
5 years, 9 months ago (2015-03-23 20:27:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
5d0a133ecd6625f30c6491d502f12f26a0bef32d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698