Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: snapshot/mac/mach_o_image_reader.h

Issue 1019243006: Tolerate weird cl_kernels modules (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Check the Mach-O file type too Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | snapshot/mac/mach_o_image_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/mac/mach_o_image_reader.h
diff --git a/snapshot/mac/mach_o_image_reader.h b/snapshot/mac/mach_o_image_reader.h
index 23e4a90fd8296df61c02c7a3897c505aac69d4f0..7047bc6a6fae60d103e1e1c883f7375fbb4825a8 100644
--- a/snapshot/mac/mach_o_image_reader.h
+++ b/snapshot/mac/mach_o_image_reader.h
@@ -58,7 +58,8 @@ class MachOImageReader {
//! the remote process’ dyld information (see
//! snapshot/mac/process_types/dyld_images.proctype).
//! \param[in] name The module’s name, a string to be used in logged messages.
- //! This string is for diagnostic purposes only, and may be empty.
+ //! This string is for diagnostic purposes and to relax otherwise strict
+ //! parsing rules for common modules with known defects.
//!
//! \return `true` if the image was read successfully, including all load
//! commands. `false` otherwise, with an appropriate message logged.
@@ -316,6 +317,7 @@ class MachOImageReader {
PointerVector<MachOImageSegmentReader> segments_;
std::map<std::string, size_t> segment_map_;
+ std::string module_name_;
std::string module_info_;
std::string dylinker_name_;
crashpad::UUID uuid_;
« no previous file with comments | « no previous file | snapshot/mac/mach_o_image_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698