Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: snapshot/mac/mach_o_image_segment_reader.h

Issue 1019243006: Tolerate weird cl_kernels modules (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Check the Mach-O file type too Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « snapshot/mac/mach_o_image_reader.cc ('k') | snapshot/mac/mach_o_image_segment_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/mac/mach_o_image_segment_reader.h
diff --git a/snapshot/mac/mach_o_image_segment_reader.h b/snapshot/mac/mach_o_image_segment_reader.h
index 16b0fe33d139e78bb2d69fbfd8c668305b952222..4e6a97e36cf9c9f008a04177472e038fb177193b 100644
--- a/snapshot/mac/mach_o_image_segment_reader.h
+++ b/snapshot/mac/mach_o_image_segment_reader.h
@@ -54,12 +54,19 @@ class MachOImageSegmentReader {
//! reader, such as MachOImageReader, as it walks Mach-O load commands.
//! \param[in] load_command_info A string to be used in logged messages. This
//! string is for diagnostic purposes only, and may be empty.
+ //! \param[in] module_name The path used to load the module. This string is
+ //! used to relax otherwise strict parsing rules for common modules with
+ //! known defects.
+ //! \param[in] file_type The module’s Mach-O file type. This is used to relax
+ //! otherwise strict parsing rules for common modules with known defects.
//!
//! \return `true` if the load command was read successfully. `false`
//! otherwise, with an appropriate message logged.
bool Initialize(ProcessReader* process_reader,
mach_vm_address_t load_command_address,
- const std::string& load_command_info);
+ const std::string& load_command_info,
+ const std::string& module_name,
+ uint32_t file_type);
//! \brief Sets the image’s slide value.
//!
« no previous file with comments | « snapshot/mac/mach_o_image_reader.cc ('k') | snapshot/mac/mach_o_image_segment_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698