Removing chrome.pushMessaging API

Removing chrome.pushMessaging API and related tests.

BUG=448165
Committed: https://crrev.com/8ebeef2e977c89293d66a5e7f55f9cf30017e336
Cr-Commit-Position: refs/heads/master@{#321877}

[fgorski, 2015-03-18 23:10:04]

fgorski@chromium.org changed reviewers:
+ atwilson@chromium.org, jhawkins@chromium.org, kalman@chromium.org

[fgorski, 2015-03-18 23:10:04]

atwilson@chromium.org: Please review changes in 
c/browser/background

kalman@chromium.org: Please review changes in 
c/common/extensions,
c/browser/extensions

jhawkins@chromium.org: Please review changes in 
c/*.gypi
c/test/data/e/a/push_*
c/test/data/ext_auto/*

[not at google - send to devlin, 2015-03-18 23:14:58]

lgtm, but let me know if you want me to take a look at any documentation changes
you make

https://codereview.chromium.org/1018643003/diff/60001/chrome/common/extension...
File chrome/common/extensions/api/_api_features.json (right):

https://codereview.chromium.org/1018643003/diff/60001/chrome/common/extension...
chrome/common/extensions/api/_api_features.json:1: // Copyright (c) 2012 The
Chromium Authors. All rights reserved.
You also need to delete chrome/common/extensions/api/push_messaging.idl

https://codereview.chromium.org/1018643003/diff/60001/chrome/common/extension...
File chrome/common/extensions/docs/templates/json/apps_sidenav.json (left):

https://codereview.chromium.org/1018643003/diff/60001/chrome/common/extension...
chrome/common/extensions/docs/templates/json/apps_sidenav.json:138: "href":
"/apps/pushMessaging"
There are also files like pushMessaging.html which you shouldn't *delete*
(broken links are bad), but you should just change to be "chrome.pushMessaging
is no longer supported, use chrome.gcm instead". Similar to what you already
have - just without any of the unnecessary documentation still there.

[Andrew T Wilson (Slow), 2015-03-19 07:18:39]

Mostly LG with one concern.

https://codereview.chromium.org/1018643003/diff/60001/chrome/browser/backgrou...
File chrome/browser/background/background_mode_manager_unittest.cc (left):

https://codereview.chromium.org/1018643003/diff/60001/chrome/browser/backgrou...
chrome/browser/background/background_mode_manager_unittest.cc:928:
manager_->SetHasShownBalloon(false);
So, I'm not that familiar with this "ephemeral app" stuff (don't think I was
looped in when it was added), but it looks like we no longer test this
functionality? Did ephemeral apps go away now that we've removed push messaging?
Or should you change this test to not rely on push messaging permission, but to
still test ephemeral apps?

[James Hawkins, 2015-03-19 16:05:06]

lgtm

[fgorski, 2015-03-19 18:22:42]

fgorski@chromium.org changed reviewers:
+ benwells@chromium.org

[fgorski, 2015-03-19 18:22:43]

+ Ben Wells
Please take a look at the background_mode_manager and comment from atwilson. I
discussed it with Dmitry and it is possible that with pushMessaging going away,
there is a chance to simplify more logic in background related code.

Also, if there is a reasonable manifest to replace the existing one with, please
let me know.

[fgorski, 2015-03-19 20:50:44]

kalman@,

Please take a look at updated documentation, here is what I propose:
* removing idl causes a Not Found error on the apps/pushMessaging and
extensions/pushMessaging
* I am adding article for above explaining removal of the API and pointing to
chrome.gcm
* I am also updating gcm_tos and gcm_server to mention the removal...

(I am ok to drop the content from the two above, as the links will still work,
but point to a blunt removal message). Because we are losing the API
documentation, due to IDL removal, there will be asymmetry here, which bugs me a
bit.

WDYT?

[not at google - send to devlin, 2015-03-19 20:54:25]

lgtm

https://codereview.chromium.org/1018643003/diff/80001/chrome/common/extension...
File chrome/common/extensions/docs/templates/articles/cloudMessagingV1.html
(right):

https://codereview.chromium.org/1018643003/diff/80001/chrome/common/extension...
chrome/common/extensions/docs/templates/articles/cloudMessagingV1.html:5: This
document explains sending messages to chrome.pushMessaging API, which is
I would just replace this whole thing with "The pushMessaging API was deleted in
Chrome 43. This document exists for posterity only." No need to mention the
deprecation thing anymore IMO. Same for the other documentation files.

[benwells, 2015-03-20 00:39:12]

https://codereview.chromium.org/1018643003/diff/60001/chrome/browser/backgrou...
File chrome/browser/background/background_mode_manager_unittest.cc (left):

https://codereview.chromium.org/1018643003/diff/60001/chrome/browser/backgrou...
chrome/browser/background/background_mode_manager_unittest.cc:928:
manager_->SetHasShownBalloon(false);
On 2015/03/19 07:18:38, Andrew T Wilson wrote:
> So, I'm not that familiar with this "ephemeral app" stuff (don't think I was
> looped in when it was added), but it looks like we no longer test this
> functionality? Did ephemeral apps go away now that we've removed push
messaging?
> Or should you change this test to not rely on push messaging permission, but
to
> still test ephemeral apps?

Ephemeral apps were never released. I'm planning to delete the code soon so this
is fine.

[fgorski, 2015-03-23 21:45:13]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2015-03-23 21:45:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
jhawkins@chromium.org, kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1018643003/#ps100001
(title: "Updates to documentation per kalman's comments")

[commit-bot: I haz the power, 2015-03-23 21:45:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1018643003/100001

[commit-bot: I haz the power, 2015-03-23 22:35:55]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-03-23 22:37:59]

Patchset 6 (id:??) landed as
https://crrev.com/8ebeef2e977c89293d66a5e7f55f9cf30017e336
Cr-Commit-Position: refs/heads/master@{#321877}

[johnme, 2015-05-06 13:16:32]

This removed two web push_messaging files from chrome/chrome_tests_unit.gypi!
We've re-added them in https://codereview.chromium.org/1129783002.