Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4018)

Unified Diff: chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher_unittest.cc

Issue 1018643003: Removing chrome.pushMessaging API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updates to documentation per kalman's comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher_unittest.cc
diff --git a/chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher_unittest.cc b/chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher_unittest.cc
deleted file mode 100644
index d26165ca3e35c222fefdee8dd4f6ec98eaff8610..0000000000000000000000000000000000000000
--- a/chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher_unittest.cc
+++ /dev/null
@@ -1,107 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "testing/gtest/include/gtest/gtest.h"
-
-#include <string>
-
-#include "chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.h"
-#include "chrome/browser/extensions/api/push_messaging/push_messaging_api.h"
-#include "net/url_request/test_url_fetcher_factory.h"
-
-namespace {
-
-static const char kGoodData[] = "{ \"id\" : \"My-channel-id\" }";
-static const char kBadJsonData[] = "I am not a JSON string";
-static const char kDictionaryMissingIdData[] = "{ \"foo\" : \"bar\" }";
-static const char kNonDictionaryJsonData[] = "{ 0.5 }";
-
-// Delegate class for catching notifications from the ObfuscatedGaiaIdFetcher.
-class TestDelegate : public extensions::ObfuscatedGaiaIdFetcher::Delegate {
- public:
- void OnObfuscatedGaiaIdFetchSuccess(
- const std::string& obfuscated_id) override {
- succeeded_ = true;
- }
- void OnObfuscatedGaiaIdFetchFailure(
- const GoogleServiceAuthError& error) override {
- failed_ = true;
- }
- TestDelegate() : succeeded_(false), failed_(false) {}
- ~TestDelegate() override {}
- bool succeeded() const { return succeeded_; }
- bool failed() const { return failed_; }
-
- private:
- bool succeeded_;
- bool failed_;
- DISALLOW_COPY_AND_ASSIGN(TestDelegate);
-};
-
-} // namespace
-
-namespace extensions {
-
-TEST(ObfuscatedGaiaIdFetcherTest, ParseResponse) {
- // Try a good response string.
- std::string channel_id_out1;
- bool ret1 = ObfuscatedGaiaIdFetcher::ParseResponse(
- kGoodData, &channel_id_out1);
- EXPECT_EQ("My-channel-id", channel_id_out1);
- EXPECT_TRUE(ret1);
-
- // Try badly formatted JSON.
- std::string channel_id_out2;
- bool ret2 = ObfuscatedGaiaIdFetcher::ParseResponse(
- kBadJsonData, &channel_id_out2);
- EXPECT_TRUE(channel_id_out2.empty());
- EXPECT_FALSE(ret2);
-
- // Try a JSON dictionary with no "id" value.
- std::string channel_id_out3;
- bool ret3 = ObfuscatedGaiaIdFetcher::ParseResponse(
- kDictionaryMissingIdData, &channel_id_out3);
- EXPECT_TRUE(channel_id_out3.empty());
- EXPECT_FALSE(ret3);
-
- // Try JSON, but not a dictionary.
- std::string channel_id_out4;
- bool ret4 = ObfuscatedGaiaIdFetcher::ParseResponse(
- kNonDictionaryJsonData, &channel_id_out4);
- EXPECT_TRUE(channel_id_out4.empty());
- EXPECT_FALSE(ret4);
-}
-
-TEST(ObfuscatedGaiaIdFetcherTest, ProcessApiCallSuccess) {
- TestDelegate delegate;
- ObfuscatedGaiaIdFetcher fetcher(&delegate);
-
- net::TestURLFetcher url_fetcher(1, GURL("http://www.google.com"), NULL);
- url_fetcher.set_status(
- net::URLRequestStatus(net::URLRequestStatus::SUCCESS, 0));
- url_fetcher.SetResponseString(kGoodData);
-
- // Test the happy path.
- fetcher.ProcessApiCallSuccess(&url_fetcher);
- EXPECT_TRUE(delegate.succeeded());
-}
-
-TEST(ObfuscatedGaiaIdFetcherTest, ProcessApiCallFailure) {
- TestDelegate delegate;
- ObfuscatedGaiaIdFetcher fetcher(&delegate);
-
- net::TestURLFetcher url_fetcher(1, GURL("http://www.google.com"), NULL);
- url_fetcher.set_status(
- net::URLRequestStatus(net::URLRequestStatus::SUCCESS, 0));
- url_fetcher.SetResponseString(kDictionaryMissingIdData);
-
- // Test with bad data, ensure it fails.
- fetcher.ProcessApiCallSuccess(&url_fetcher);
- EXPECT_TRUE(delegate.failed());
-
- // TODO(petewil): add case for when the base class fails and calls
- // ProcessApiCallFailure
-}
-
-} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698