Removing chrome.pushMessaging API

chrome/browser/background/background_mode_manager_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/background/background_mode_manager.h"
@@ skipping 855 matching lines @@
 
   scoped_refptr<extensions::Extension> upgraded_no_bg_ext_has_bg(
     CreateExtension(
         extensions::Manifest::COMMAND_LINE,
         "{\"name\": \"Regular Extension\", "
         "\"version\": \"2.0\","
         "\"manifest_version\": 2,"
         "\"permissions\": [\"background\"]}",
         "ID-2"));
 
-  scoped_refptr<extensions::Extension> ephemeral_app(
-    CreateExtension(
-        extensions::Manifest::COMMAND_LINE,
-        "{\"name\": \"Ephemeral App\", "
-        "\"version\": \"1.0\","
-        "\"manifest_version\": 2,"
-        "\"permissions\": [\"pushMessaging\"]}",
-        "ID-3"));
-
   static_cast<extensions::TestExtensionSystem*>(
       extensions::ExtensionSystem::Get(profile_))
       ->CreateExtensionService(base::CommandLine::ForCurrentProcess(),
                                base::FilePath(), false);
 
   ExtensionService* service =
       extensions::ExtensionSystem::Get(profile_)->extension_service();
   ASSERT_FALSE(service->is_ready());
   service->Init();
 
@@ skipping 21 matching lines @@
     EXPECT_CALL(*manager_, EnableLaunchOnStartup(true)).Times(Exactly(1));
   }
   service->AddExtension(upgraded_bg_ext.get());
   Mock::VerifyAndClearExpectations(manager_.get());
   EXPECT_FALSE(manager_->HasShownBalloon());
 
   // Upgrading an extension that didn't have background to one that does should
   // show the balloon.
   service->AddExtension(upgraded_no_bg_ext_has_bg.get());
   EXPECT_TRUE(manager_->HasShownBalloon());
-
-  // Installing an ephemeral app should not show the balloon.
-  manager_->SetHasShownBalloon(false);

[Andrew T Wilson (Slow), 2015/03/19 07:18:38]

So, I'm not that familiar with this "ephemeral app" stuff (don't think I was
looped in when it was added), but it looks like we no longer test this
functionality? Did ephemeral apps go away now that we've removed push messaging?
Or should you change this test to not rely on push messaging permission, but to
still test ephemeral apps?

[benwells, 2015/03/20 00:39:12]

Ephemeral apps were never released. I'm planning to delete the code soon so this
is fine.

-  AddEphemeralApp(ephemeral_app.get(), service);
-  EXPECT_FALSE(manager_->HasShownBalloon());
-
-  // Promoting the ephemeral app to a regular installed app should now show
-  // the balloon.
-  service->PromoteEphemeralApp(ephemeral_app.get(), false /* from sync */);
-  EXPECT_TRUE(manager_->HasShownBalloon());
 }