[Extensions] Combine developerPrivate.inspect and developerPrivate.openDevTools

chrome/common/extensions/api/developer_private.idl

Index: chrome/common/extensions/api/developer_private.idl
diff --git a/chrome/common/extensions/api/developer_private.idl b/chrome/common/extensions/api/developer_private.idl
index d7e155598bfcfc08c477516f54f55b96c8a90833..1d69dd6dfc75d9bd391737c05eb6e32835ac4590 100644
--- a/chrome/common/extensions/api/developer_private.idl
+++ b/chrome/common/extensions/api/developer_private.idl
@@ -218,14 +218,6 @@ namespace developerPrivate {
     boolean? includeTerminated;
   };
 
-  // TODO(devlin): Combine inspect and openDevTools?
-  dictionary InspectOptions {
-    DOMString extension_id;
-    (DOMString or long) render_process_id;
-    (DOMString or long) render_view_id;
-    boolean incognito;
-  };
-
   dictionary ReloadOptions {
     // If false, an alert dialog will show in the event of a reload error.
     // Defaults to false.
@@ -332,12 +324,16 @@ namespace developerPrivate {
   };
 
   dictionary OpenDevToolsProperties {
+    DOMString? extensionId;

[not at google - send to devlin, 2015/03/19 18:52:49]

Comment here and below, e.g. what happens if it's left out.

[Devlin, 2015/03/19 20:27:33]

Done.

+
     // The ID of the render view in which the error occurred.
     long renderViewId;
 
     // The ID of the process in which the error occurred.
     long renderProcessId;
 
+    boolean? incognito;
+
     // The URL in which the error occurred.
     DOMString? url;
 
@@ -392,11 +388,6 @@ namespace developerPrivate {
     static void showPermissionsDialog(DOMString extensionId,
                                       optional VoidCallback callback);
 
-    // Opens a developer tools inspection window.
-    // |options| : The details about the inspection.
-    static void inspect(InspectOptions options,
-                        optional VoidCallback callback);
-
     // Enables / Disables file access for an extension.
     // |extensionId| : The id of the extension to set file access for.
     // |allow| : Whether or not to allow file access for the extension.
@@ -457,7 +448,8 @@ namespace developerPrivate {
                                   RequestFileSourceCallback callback);
 
     // Open the developer tools to focus on a particular error.
-    static void openDevTools(OpenDevToolsProperties properties);
+    static void openDevTools(OpenDevToolsProperties properties,
+                             optional VoidCallback callback);
   };
 
   interface Events {