[Extensions] Combine developerPrivate.inspect and developerPrivate.openDevTools

chrome/common/extensions/api/developer_private.idl

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // developerPrivate API.
 // This is a private API exposing developing and debugging functionalities for
 // apps and extensions.
 namespace developerPrivate {
 
   // DEPRECATED: Prefer ExtensionType.
@@ skipping 200 matching lines @@
 
     // All views of the current extension.
     ItemInspectView[] views;
   };
 
   dictionary GetExtensionsInfoOptions {
     boolean? includeDisabled;
     boolean? includeTerminated;
   };
 
-  // TODO(devlin): Combine inspect and openDevTools?
-  dictionary InspectOptions {
-    DOMString extension_id;
-    (DOMString or long) render_process_id;
-    (DOMString or long) render_view_id;
-    boolean incognito;
-  };
-
   dictionary ReloadOptions {
     // If false, an alert dialog will show in the event of a reload error.
     // Defaults to false.
     boolean? failQuietly;
   };
 
   dictionary LoadUnpackedOptions {
     // If false, an alert dialog will show in the event of a reload error.
     // Defaults to false.
     boolean? failQuietly;
@@ skipping 86 matching lines @@
     DOMString afterHighlight;
 
     // A title for the file in the form '<extension name>: <file name>'.
     DOMString title;
 
     // The error message.
     DOMString message;
   };
 
   dictionary OpenDevToolsProperties {
+    DOMString? extensionId;

[not at google - send to devlin, 2015/03/19 18:52:49]

Comment here and below, e.g. what happens if it's left out.

[Devlin, 2015/03/19 20:27:33]

Done.

+
     // The ID of the render view in which the error occurred.
     long renderViewId;
 
     // The ID of the process in which the error occurred.
     long renderProcessId;
 
+    boolean? incognito;
+
     // The URL in which the error occurred.
     DOMString? url;
 
     // The line to focus the devtools at.
     long? lineNumber;
 
     // The column to focus the devtools at.
     long? columnNumber;
   };
 
@@ skipping 34 matching lines @@
     // DEPRECATED: Prefer getExtensionsInfo.
     static void getItemsInfo(boolean includeDisabled,
                              boolean includeTerminated,
                              ItemsInfoCallback callback);
 
     // Opens a permissions dialog.
     // |extensionId| : The id of the extension to show permissions for.
     static void showPermissionsDialog(DOMString extensionId,
                                       optional VoidCallback callback);
 
-    // Opens a developer tools inspection window.
-    // |options| : The details about the inspection.
-    static void inspect(InspectOptions options,
-                        optional VoidCallback callback);
-
     // Enables / Disables file access for an extension.
     // |extensionId| : The id of the extension to set file access for.
     // |allow| : Whether or not to allow file access for the extension.
     static void allowFileAccess(DOMString extensionId,
                                 boolean allow,
                                 optional VoidCallback callback);
 
     // Reloads a given extension.
     // |extensionId| : The id of the extension to reload.
     // |options| : Additional configuration parameters.
@@ skipping 40 matching lines @@
 
     // Returns true if the profile is managed.
     static void isProfileManaged(BooleanCallback callback);
 
     // Reads and returns the contents of a file related to an extension which
     // caused an error.
     static void requestFileSource(RequestFileSourceProperties properties,
                                   RequestFileSourceCallback callback);
 
     // Open the developer tools to focus on a particular error.
-    static void openDevTools(OpenDevToolsProperties properties);
+    static void openDevTools(OpenDevToolsProperties properties,
+                             optional VoidCallback callback);
   };
 
   interface Events {
     // Fired when a item state is changed.
     static void onItemStateChanged(EventData response);
   };
 
 };