chrome/browser/resources/extensions/extension_list.js - Issue 1018493002: [Extensions] Combine developerPrivate.inspect and developerPrivate.openDevTools

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 1018493002: [Extensions] Combine developerPrivate.inspect and developerPrivate.openDevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/common/extensions/api/developer_private.idl » ('j') | chrome/common/extensions/api/developer_private.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/extensions/extension_list.js

diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js

index 2e5965897aab48a6344448647a78c06748bb3e7f..2af246a01e3c44f92889327f96709cba5c14c506 100644

--- a/chrome/browser/resources/extensions/extension_list.js

+++ b/chrome/browser/resources/extensions/extension_list.js

@@ -734,10 +734,10 @@ cr.define('extensions', function() {

' ' + loadTimeData.getString('viewInactive') : '');

link.textContent = label;

link.clickHandler = function(e) {

- chrome.developerPrivate.inspect({

- extension_id: extension.id,

- render_process_id: view.renderProcessId,

- render_view_id: view.renderViewId,

+ chrome.developerPrivate.openDevTools({

+ extensionId: extension.id,

+ renderProcessId: view.renderProcessId,

+ renderViewId: view.renderViewId,

incognito: view.incognito

});

};