[Extensions] Combine developerPrivate.inspect and developerPrivate.openDevTools

[Extensions] Combine developerPrivate.inspect and developerPrivate.openDevTools

Combine the two api functions developerPrivate.inspect and
developerPrivate.openDevTools, and provide a custom binding wrapper to
maintain compatability with developerPrivate.inspect.

BUG=461039
Committed: https://crrev.com/e90ab53f4d166e80a2dce87420dbdb648626d506
Cr-Commit-Position: refs/heads/master@{#321629}

[Devlin, 2015-03-19 17:27:31]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-03-19 17:28:10]

rdevlin.cronin@chromium.org changed reviewers:
+ kalman@chromium.org

[not at google - send to devlin, 2015-03-19 18:52:50]

lgtm for expediency, I'm sure you can handle the setHandleRequest comment. Just
find some other example.

https://codereview.chromium.org/1018493002/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/developer_private.idl (right):

https://codereview.chromium.org/1018493002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/developer_private.idl:327: DOMString? extensionId;
Comment here and below, e.g. what happens if it's left out.

https://codereview.chromium.org/1018493002/diff/20001/chrome/renderer/resourc...
File chrome/renderer/resources/extensions/developer_private_custom_bindings.js
(right):

https://codereview.chromium.org/1018493002/diff/20001/chrome/renderer/resourc...
chrome/renderer/resources/extensions/developer_private_custom_bindings.js:29:
bindingsAPI.compiledApi.inspect = function(options, callback) {
In this case you might be better off using setHandleRequest('inspect') which
does argument normalization and parsing for you. Maybe. It all just looks more
hands-on that I would have expected to be necessary.

https://codereview.chromium.org/1018493002/diff/20001/chrome/renderer/resourc...
chrome/renderer/resources/extensions/developer_private_custom_bindings.js:31: if
(typeof(renderViewId) == 'string') {
typeof is a keyword not a function

[Devlin, 2015-03-19 20:27:33]

https://codereview.chromium.org/1018493002/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/developer_private.idl (right):

https://codereview.chromium.org/1018493002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/developer_private.idl:327: DOMString? extensionId;
On 2015/03/19 18:52:49, kalman wrote:
> Comment here and below, e.g. what happens if it's left out.

Done.

https://codereview.chromium.org/1018493002/diff/20001/chrome/renderer/resourc...
File chrome/renderer/resources/extensions/developer_private_custom_bindings.js
(right):

https://codereview.chromium.org/1018493002/diff/20001/chrome/renderer/resourc...
chrome/renderer/resources/extensions/developer_private_custom_bindings.js:29:
bindingsAPI.compiledApi.inspect = function(options, callback) {
On 2015/03/19 18:52:49, kalman wrote:
> In this case you might be better off using setHandleRequest('inspect') which
> does argument normalization and parsing for you. Maybe. It all just looks more
> hands-on that I would have expected to be necessary.

Well, setHandleRequest looks like the right thing to use (also for
'allowFileAccess' and 'allowIncognito').  Unfortunately, it doesn't really help
with the hands-on part, because we need to handle the case of string values for
ids (since that what the API started as).

The downside is now we need to keep the definitions in the idl file, but that's
probably worth it for the errors and typesafety from the autogenerated bindings.

https://codereview.chromium.org/1018493002/diff/20001/chrome/renderer/resourc...
chrome/renderer/resources/extensions/developer_private_custom_bindings.js:31: if
(typeof(renderViewId) == 'string') {
On 2015/03/19 18:52:49, kalman wrote:
> typeof is a keyword not a function

Huh. Never knew (obviously works fine when called typeof(foo).  Done.

[Devlin, 2015-03-20 19:38:10]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-03-20 19:38:10]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1018493002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-03-20 19:38:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1018493002/40001

[commit-bot: I haz the power, 2015-03-20 20:57:34]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-03-20 20:58:33]

Patchset 2 (id:??) landed as
https://crrev.com/e90ab53f4d166e80a2dce87420dbdb648626d506
Cr-Commit-Position: refs/heads/master@{#321629}