Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: chrome/renderer/resources/extensions/developer_private_custom_bindings.js

Issue 1018493002: [Extensions] Combine developerPrivate.inspect and developerPrivate.openDevTools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/developer_private.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/resources/extensions/developer_private_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/developer_private_custom_bindings.js b/chrome/renderer/resources/extensions/developer_private_custom_bindings.js
index fb96186b3f4035ce6eac199783ca2be354ffee8c..3c41a5ebf98960507eecdda77a6f90db9a944f53 100644
--- a/chrome/renderer/resources/extensions/developer_private_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/developer_private_custom_bindings.js
@@ -26,15 +26,38 @@ binding.registerCustomHook(function(bindingsAPI) {
// TODO(devlin): Migrate callers off developerPrivate.enable.
bindingsAPI.compiledApi.enable = chrome.management.setEnabled;
- bindingsAPI.compiledApi.allowFileAccess = function(id, allow, callback) {
+ apiFunctions.setHandleRequest('allowFileAccess',
+ function(id, allow, callback) {
chrome.developerPrivate.updateExtensionConfiguration(
{extensionId: id, fileAccess: allow}, callback);
- };
+ });
- bindingsAPI.compiledApi.allowIncognito = function(id, allow, callback) {
+ apiFunctions.setHandleRequest('allowIncognito',
+ function(id, allow, callback) {
chrome.developerPrivate.updateExtensionConfiguration(
{extensionId: id, incognitoAccess: allow}, callback);
- };
+ });
+
+ apiFunctions.setHandleRequest('inspect', function(options, callback) {
+ var renderViewId = options.render_view_id;
+ if (typeof renderViewId == 'string') {
+ renderViewId = parseInt(renderViewId);
+ if (isNaN(renderViewId))
+ throw new Error('Invalid value for render_view_id');
+ }
+ var renderProcessId = options.render_process_id;
+ if (typeof renderProcessId == 'string') {
+ renderProcessId = parseInt(renderProcessId);
+ if (isNaN(renderProcessId))
+ throw new Error('Invalid value for render_process_id');
+ }
+ chrome.developerPrivate.openDevTools({
+ extensionId: options.extension_id,
+ renderProcessId: renderProcessId,
+ renderViewId: renderViewId,
+ incognito: options.incognito
+ }, callback);
+ });
});
exports.binding = binding.generate();
« no previous file with comments | « chrome/common/extensions/api/developer_private.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698