[Icons NTP] Allow chrome-search:// large-icon and fallback-icon hosts to use <view_id>/<restricted_…

chrome/renderer/searchbox/searchbox.h

Index: chrome/renderer/searchbox/searchbox.h
diff --git a/chrome/renderer/searchbox/searchbox.h b/chrome/renderer/searchbox/searchbox.h
index d0821ca5aedcb6fdca58af359f6b58e90d44c10d..7374835a80be418ef1aa1b52cd8b5c859d85175f 100644
--- a/chrome/renderer/searchbox/searchbox.h
+++ b/chrome/renderer/searchbox/searchbox.h
@@ -58,6 +58,18 @@ class SearchBox : public content::RenderViewObserver,
   bool GenerateFaviconURLFromTransientURL(const GURL& transient_url,
                                           GURL* url) const;
 
+  // Valid forms of |transient_url|:
+  //    chrome-search://large-icon/<view_id>/<restricted_id>
+  //    chrome-search://large-icon/<size>/<view_id>/<restricted_id>
+  bool GenerateLargeIconURLFromTransientURL(const GURL& transient_url,

[James Hawkins, 2015/03/17 21:46:41]

It seems like having three similarly named methods is less preferable than
having one method which is configurable (say with a parameter).  What do you
think?

[huangs, 2015/03/18 21:43:10]

I think we can even do better: Yank all these out into a separate class!

There's high pressure to have the feature though.  I'd rather defer cleanup
later.  Please see crbug.com/468320 to track the refactoring.

+                                            GURL* url) const;
+
+  // Valid forms of |transient_url|:
+  //    chrome-search://fallback-icon/<view_id>/<restricted_id>
+  //    chrome-search://fallback-icon/<icon styles>/<view_id>/<restricted_id>
+  bool GenerateFallbackIconURLFromTransientURL(const GURL& transient_url,
+                                               GURL* url) const;
+
   // Generates the thumbnail URL of the most visited item specified by the
   // |transient_url|. If the |transient_url| is valid, returns true and fills in
   // |url|. If the |transient_url| is invalid, returns false  and |url| is not