[Icons NTP] Allow chrome-search:// large-icon and fallback-icon hosts to use <view_id>/<restricted_…

chrome/renderer/chrome_content_renderer_client.cc

Index: chrome/renderer/chrome_content_renderer_client.cc
diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc
index 3daf11327c4033207c387c59ca2667e16e6613e1..68b0e3d46c8afb61ccedd3ae93fdd07204a4e6b3 100644
--- a/chrome/renderer/chrome_content_renderer_client.cc
+++ b/chrome/renderer/chrome_content_renderer_client.cc
@@ -1380,8 +1380,12 @@ bool ChromeContentRendererClient::WillSendRequest(
   if (search_box && url.SchemeIs(chrome::kChromeSearchScheme)) {
     if (url.host() == chrome::kChromeUIThumbnailHost)
       return search_box->GenerateThumbnailURLFromTransientURL(url, new_url);
-    else if (url.host() == chrome::kChromeUIFaviconHost)
+    if (url.host() == chrome::kChromeUIFaviconHost)

[James Hawkins, 2015/03/17 21:46:41]

Shouldn't these all be else if since the hosts are mutually exclusive?

[huangs, 2015/03/18 21:43:10]

I thought you don't need else if returning?

       return search_box->GenerateFaviconURLFromTransientURL(url, new_url);
+    if (url.host() == chrome::kChromeUILargeIconHost)
+      return search_box->GenerateLargeIconURLFromTransientURL(url, new_url);
+    if (url.host() == chrome::kChromeUIFallbackIconHost)
+      return search_box->GenerateFallbackIconURLFromTransientURL(url, new_url);
   }
 
   return false;