[Icons NTP] Allow chrome-search:// large-icon and fallback-icon hosts to use <view_id>/<restricted_…

chrome/renderer/searchbox/searchbox.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_RENDERER_SEARCHBOX_SEARCHBOX_H_
 #define CHROME_RENDERER_SEARCHBOX_SEARCHBOX_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 40 matching lines @@
   // |url|. If the |transient_url| is invalid, returns true and |url| is set to
   // "chrome-search://favicon/" in order to prevent the invalid URL to be
   // requested.
   //
   // Valid forms of |transient_url|:
   //    chrome-search://favicon/<view_id>/<restricted_id>
   //    chrome-search://favicon/<favicon_parameters>/<view_id>/<restricted_id>
   bool GenerateFaviconURLFromTransientURL(const GURL& transient_url,
                                           GURL* url) const;
 
+  // Valid forms of |transient_url|:
+  //    chrome-search://large-icon/<view_id>/<restricted_id>
+  //    chrome-search://large-icon/<size>/<view_id>/<restricted_id>
+  bool GenerateLargeIconURLFromTransientURL(const GURL& transient_url,

[James Hawkins, 2015/03/17 21:46:41]

It seems like having three similarly named methods is less preferable than
having one method which is configurable (say with a parameter).  What do you
think?

[huangs, 2015/03/18 21:43:10]

I think we can even do better: Yank all these out into a separate class!

There's high pressure to have the feature though.  I'd rather defer cleanup
later.  Please see crbug.com/468320 to track the refactoring.

+                                            GURL* url) const;
+
+  // Valid forms of |transient_url|:
+  //    chrome-search://fallback-icon/<view_id>/<restricted_id>
+  //    chrome-search://fallback-icon/<icon styles>/<view_id>/<restricted_id>
+  bool GenerateFallbackIconURLFromTransientURL(const GURL& transient_url,
+                                               GURL* url) const;
+
   // Generates the thumbnail URL of the most visited item specified by the
   // |transient_url|. If the |transient_url| is valid, returns true and fills in
   // |url|. If the |transient_url| is invalid, returns false  and |url| is not
   // set.
   //
   // Valid form of |transient_url|:
   //    chrome-search://thumb/<render_view_id>/<most_visited_item_id>
   bool GenerateThumbnailURLFromTransientURL(const GURL& transient_url,
                                             GURL* url) const;
 
@@ skipping 87 matching lines @@
   ThemeBackgroundInfo theme_info_;
   base::string16 query_;
   EmbeddedSearchRequestParams embedded_search_request_params_;
   int start_margin_;
   InstantSuggestion suggestion_;
 
   DISALLOW_COPY_AND_ASSIGN(SearchBox);
 };
 
 #endif  // CHROME_RENDERER_SEARCHBOX_SEARCHBOX_H_