Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 1017793002: Revert of Do not allow asan_symbolize.py to fall back to addr2line/atos. (Closed)

Created:
5 years, 9 months ago by earthdok
Modified:
5 years, 9 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Do not allow asan_symbolize.py to fall back to addr2line/atos. (patchset #1 id:1 of https://codereview.chromium.org/983083004/) Reason for revert: Turns out the fall back to addr2line happens routinely. We need to fix that before proceeding with this change. Original issue's description: > Do not allow asan_symbolize.py to fall back to addr2line/atos. > > For performance reasons we want to stick to llvm-symbolizer. > This also rolls the third-party asan_symbolize.py to r231492. > > BUG=415179 > TBR=glider@chromium.org > NOTRY=true > > Committed: https://crrev.com/2ee9a8ae1e39433fc8df07c27256963715747bbb > Cr-Commit-Position: refs/heads/master@{#319460} TBR=glider@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=415179 Committed: https://crrev.com/a5ffcd6982734e6429518c63fa42c02339eae74b Cr-Commit-Position: refs/heads/master@{#320955}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M tools/valgrind/asan/asan_symbolize.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/valgrind/asan/third_party/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M tools/valgrind/asan/third_party/asan_symbolize.py View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
earthdok
Created Revert of Do not allow asan_symbolize.py to fall back to addr2line/atos.
5 years, 9 months ago (2015-03-17 19:17:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017793002/1
5 years, 9 months ago (2015-03-17 19:20:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 19:24:37 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 19:25:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5ffcd6982734e6429518c63fa42c02339eae74b
Cr-Commit-Position: refs/heads/master@{#320955}

Powered by Google App Engine
This is Rietveld 408576698