tools/valgrind/asan/third_party/asan_symbolize.py - Issue 1017793002: Revert of Do not allow asan_symbolize.py to fall back to addr2line/atos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/valgrind/asan/third_party/asan_symbolize.py

Issue 1017793002: Revert of Do not allow asan_symbolize.py to fall back to addr2line/atos. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/valgrind/asan/third_party/asan_symbolize.py

diff --git a/tools/valgrind/asan/third_party/asan_symbolize.py b/tools/valgrind/asan/third_party/asan_symbolize.py

index b9d3ad3ad2fe6b7b9c3b96d9b366149387d16291..59fceaaed814c031fc08ea301f146cfe862a3e8a 100755

--- a/tools/valgrind/asan/third_party/asan_symbolize.py

+++ b/tools/valgrind/asan/third_party/asan_symbolize.py

@@ -23,7 +23,6 @@

binary_name_filter = None

fix_filename_patterns = None

logfile = sys.stdin

-allow_system_symbolizer = True

# FIXME: merge the code that calls fix_filename().

def fix_filename(file_name):

@@ -393,8 +392,6 @@

[BreakpadSymbolizerFactory(binary), self.llvm_symbolizers[binary]])

result = symbolizers[binary].symbolize(addr, binary, offset)

if result is None:

- if not allow_system_symbolizer:

- raise Exception('Failed to launch or use llvm-symbolizer.')

# Initialize system symbolizer only if other symbolizers failed.

symbolizers[binary].append_symbolizer(

SystemSymbolizerFactory(self.system, addr, binary))

« no previous file with comments | « tools/valgrind/asan/third_party/README.chromium ('k') | no next file » | no next file with comments »