tools/valgrind/asan/asan_symbolize.py - Issue 1017793002: Revert of Do not allow asan_symbolize.py to fall back to addr2line/atos.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/valgrind/asan/asan_symbolize.py

Issue 1017793002: Revert of Do not allow asan_symbolize.py to fall back to addr2line/atos. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/valgrind/asan/asan_symbolize.py

diff --git a/tools/valgrind/asan/asan_symbolize.py b/tools/valgrind/asan/asan_symbolize.py

index 898edf4844d4b3346d81a40fd527e0dc4f7b0f92..010740671aae94880bfaa87f659a55054ff983ff 100755

--- a/tools/valgrind/asan/asan_symbolize.py

+++ b/tools/valgrind/asan/asan_symbolize.py

@@ -246,9 +246,6 @@

disable_buffering()

set_symbolizer_path()

- # Disallow fallback to addr2line/atos if llvm-symbolizer is not present. Those

- # are slow and we don't want to use them ever.

- asan_symbolize.allow_system_symbolizer = False

asan_symbolize.demangle = True

asan_symbolize.fix_filename_patterns = args.strip_path_prefix

# Most source paths for Chromium binaries start with

« no previous file with comments | « no previous file | tools/valgrind/asan/third_party/README.chromium » ('j') | no next file with comments »