|
Replace 'operator*' with explicit 'get' method on SmartPointer
Made operator* return reference to the raw type, not pointer. New method 'get()' should be used when raw pointer is needed.
Also removed useless inline modifier from the SmaprtPointer methods and added const modifier to the methods that don't change smart pointer.
Made ~SmartPointerBase protected to avoid accidental calls of the non-virtual base class's destructor.
drive-by: fixed use after free in src/factory.cc
BUG=None
LOG=N
R=alph@chromium.org, svenpanne@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=18275
Total comments: 7
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+203 lines, -185 lines) |
Patch |
![](/static/closedtriangle.gif) |
M |
src/arm/lithium-arm.cc
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/code-stubs.cc
|
View
|
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/code-stubs-hydrogen.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/codegen.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/compiler.cc
|
View
|
|
6 chunks |
+11 lines, -11 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/d8-debug.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/d8-debug.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/debug-agent.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/deoptimizer.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/disassembler.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/factory.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/flags.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/frames.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/gdb-jit.cc
|
View
|
|
6 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/heap-profiler.h
|
View
|
|
2 chunks |
+8 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/heap-profiler.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/heap-snapshot-generator.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/hydrogen.cc
|
View
|
|
6 chunks |
+11 lines, -9 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/hydrogen-dce.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/hydrogen-gvn.cc
|
View
|
|
5 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/hydrogen-instructions.cc
|
View
|
|
4 chunks |
+9 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/ia32/lithium-ia32.cc
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/isolate.cc
|
View
|
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/jsregexp.cc
|
View
|
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/lithium-allocator.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/log.cc
|
View
|
|
11 chunks |
+16 lines, -14 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/messages.cc
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/mips/lithium-mips.cc
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/objects.cc
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/objects-printer.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/parser.cc
|
View
|
|
6 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/regexp-macro-assembler-tracer.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/runtime.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/scopes.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/smart-pointers.h
|
View
|
1
|
6 chunks |
+25 lines, -22 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/stub-cache.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
src/x64/lithium-x64.cc
|
View
|
|
3 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
test/cctest/test-api.cc
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
test/cctest/test-cpu-profiler.cc
|
View
|
|
4 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
test/cctest/test-debug.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
test/cctest/test-declarative-accessors.cc
|
View
|
|
5 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
test/cctest/test-func-name-inference.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
test/cctest/test-heap-profiler.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
test/cctest/test-parsing.cc
|
View
|
|
5 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
test/cctest/test-regexp.cc
|
View
|
|
3 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
test/cctest/test-reloc-info.cc
|
View
|
|
4 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
test/cctest/test-strings.cc
|
View
|
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
Total messages: 17 (0 generated)
|