src/debug-agent.cc - Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug-agent.cc

Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Reupload to make rietveld happy Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/debug-agent.cc

diff --git a/src/debug-agent.cc b/src/debug-agent.cc

index 51823aaf24c41a7ae9e5681489399d61149ca0ed..d3d22c9133c22f3e8f82ce42ef2ae14f87bdd744 100644

--- a/src/debug-agent.cc

+++ b/src/debug-agent.cc

@@ -192,7 +192,7 @@ void DebuggerAgent::OnSessionClosed(DebuggerAgentSession* session) {

void DebuggerAgentSession::Run() {

// Send the hello message.

- bool ok = DebuggerAgentUtil::SendConnectMessage(client_, *agent_->name_);

+ bool ok = DebuggerAgentUtil::SendConnectMessage(client_, agent_->name_.get());

if (!ok) return;

while (true) {

@@ -200,7 +200,7 @@ void DebuggerAgentSession::Run() {

SmartArrayPointer<char> message =

DebuggerAgentUtil::ReceiveMessage(client_);

- const char* msg = *message;

+ const char* msg = message.get();

bool is_closing_session = (msg == NULL);

if (msg == NULL) {

« no previous file with comments | « src/d8-debug.cc ('k') | src/deoptimizer.cc » ('j') | no next file with comments »