Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: src/d8-debug.h

Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Reupload to make rietveld happy Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/compiler.cc ('k') | src/d8-debug.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2008 the V8 project authors. All rights reserved. 1 // Copyright 2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 RemoteDebuggerEvent(int type, i::SmartArrayPointer<char> data) 128 RemoteDebuggerEvent(int type, i::SmartArrayPointer<char> data)
129 : type_(type), data_(data), next_(NULL) { 129 : type_(type), data_(data), next_(NULL) {
130 ASSERT(type == kMessage || type == kKeyboard || type == kDisconnect); 130 ASSERT(type == kMessage || type == kKeyboard || type == kDisconnect);
131 } 131 }
132 132
133 static const int kMessage = 1; 133 static const int kMessage = 1;
134 static const int kKeyboard = 2; 134 static const int kKeyboard = 2;
135 static const int kDisconnect = 3; 135 static const int kDisconnect = 3;
136 136
137 int type() { return type_; } 137 int type() { return type_; }
138 char* data() { return *data_; } 138 char* data() { return data_.get(); }
139 139
140 private: 140 private:
141 void set_next(RemoteDebuggerEvent* event) { next_ = event; } 141 void set_next(RemoteDebuggerEvent* event) { next_ = event; }
142 RemoteDebuggerEvent* next() { return next_; } 142 RemoteDebuggerEvent* next() { return next_; }
143 143
144 int type_; 144 int type_;
145 i::SmartArrayPointer<char> data_; 145 i::SmartArrayPointer<char> data_;
146 RemoteDebuggerEvent* next_; 146 RemoteDebuggerEvent* next_;
147 147
148 friend class RemoteDebugger; 148 friend class RemoteDebugger;
149 }; 149 };
150 150
151 151
152 } // namespace v8 152 } // namespace v8
153 153
154 154
155 #endif // V8_D8_DEBUG_H_ 155 #endif // V8_D8_DEBUG_H_
OLDNEW
« no previous file with comments | « src/compiler.cc ('k') | src/d8-debug.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698