Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1015983003: Disinherit PropertyCell from Cell (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disinherit PropertyCell from Cell BUG= Committed: https://crrev.com/8c0d289772649217a55011133c0e481741618330 Cr-Commit-Position: refs/heads/master@{#27274}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -30 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M src/ast.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/ast.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/heap-snapshot-generator.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects.h View 2 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Toon Verwaest
PTAL
5 years, 9 months ago (2015-03-18 10:40:52 UTC) #2
dcarney
lgtm
5 years, 9 months ago (2015-03-18 10:44:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015983003/80001
5 years, 9 months ago (2015-03-18 11:03:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015983003/80001
5 years, 9 months ago (2015-03-18 11:52:52 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:80001)
5 years, 9 months ago (2015-03-18 12:54:08 UTC) #11
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/8c0d289772649217a55011133c0e481741618330 Cr-Commit-Position: refs/heads/master@{#27274}
5 years, 9 months ago (2015-03-18 12:54:26 UTC) #12
Benedikt Meurer
5 years, 9 months ago (2015-03-19 04:59:49 UTC) #13
Message was sent while issue was closed.
Can you please add a few sentences with the motivation to CLs like these where
the subject doesn't really help with figuring out why you do this?

Powered by Google App Engine
This is Rietveld 408576698