Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: src/objects.h

Issue 1015983003: Disinherit PropertyCell from Cell (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/arm64/handler-compiler-arm64.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index bfe162b752121d6fd1480f96f250ee5ef9f4fd2c..38d8224ad13ee8fa157fee7e942e450f5483b064 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -122,7 +122,7 @@
// - Symbol
// - HeapNumber
// - Cell
-// - PropertyCell
+// - PropertyCell
// - Code
// - Map
// - Oddball
@@ -9724,7 +9724,7 @@ class Cell: public HeapObject {
};
-class PropertyCell: public Cell {
+class PropertyCell : public HeapObject {
public:
// [value]: value of the global property.
DECL_ACCESSORS(value, Object)
@@ -9754,6 +9754,7 @@ class PropertyCell: public Cell {
DECLARE_VERIFIER(PropertyCell)
// Layout description.
+ static const int kValueOffset = HeapObject::kHeaderSize;
static const int kDependentCodeOffset = kValueOffset + kPointerSize;
static const int kSize = kDependentCodeOffset + kPointerSize;
« no previous file with comments | « src/ic/arm64/handler-compiler-arm64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698