Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: src/ic/arm/handler-compiler-arm.cc

Issue 1015983003: Disinherit PropertyCell from Cell (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 __ Ret(); 190 __ Ret();
191 } 191 }
192 192
193 193
194 // Generate code to check that a global property cell is empty. Create 194 // Generate code to check that a global property cell is empty. Create
195 // the property cell at compilation time if no cell exists for the 195 // the property cell at compilation time if no cell exists for the
196 // property. 196 // property.
197 void PropertyHandlerCompiler::GenerateCheckPropertyCell( 197 void PropertyHandlerCompiler::GenerateCheckPropertyCell(
198 MacroAssembler* masm, Handle<JSGlobalObject> global, Handle<Name> name, 198 MacroAssembler* masm, Handle<JSGlobalObject> global, Handle<Name> name,
199 Register scratch, Label* miss) { 199 Register scratch, Label* miss) {
200 Handle<Cell> cell = JSGlobalObject::EnsurePropertyCell(global, name); 200 Handle<PropertyCell> cell = JSGlobalObject::EnsurePropertyCell(global, name);
201 DCHECK(cell->value()->IsTheHole()); 201 DCHECK(cell->value()->IsTheHole());
202 Handle<WeakCell> weak_cell = masm->isolate()->factory()->NewWeakCell(cell); 202 Handle<WeakCell> weak_cell = masm->isolate()->factory()->NewWeakCell(cell);
203 __ LoadWeakValue(scratch, weak_cell, miss); 203 __ LoadWeakValue(scratch, weak_cell, miss);
204 __ ldr(scratch, FieldMemOperand(scratch, Cell::kValueOffset)); 204 __ ldr(scratch, FieldMemOperand(scratch, PropertyCell::kValueOffset));
205 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex); 205 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex);
206 __ cmp(scratch, ip); 206 __ cmp(scratch, ip);
207 __ b(ne, miss); 207 __ b(ne, miss);
208 } 208 }
209 209
210 210
211 static void PushInterceptorArguments(MacroAssembler* masm, Register receiver, 211 static void PushInterceptorArguments(MacroAssembler* masm, Register receiver,
212 Register holder, Register name, 212 Register holder, Register name,
213 Handle<JSObject> holder_obj) { 213 Handle<JSObject> holder_obj) {
214 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsNameIndex == 0); 214 STATIC_ASSERT(NamedLoadHandlerCompiler::kInterceptorArgsNameIndex == 0);
(...skipping 534 matching lines...) Expand 10 before | Expand all | Expand 10 after
749 // Return the generated code. 749 // Return the generated code.
750 return GetCode(kind(), Code::NORMAL, name); 750 return GetCode(kind(), Code::NORMAL, name);
751 } 751 }
752 752
753 753
754 #undef __ 754 #undef __
755 } 755 }
756 } // namespace v8::internal 756 } // namespace v8::internal
757 757
758 #endif // V8_TARGET_ARCH_ARM 758 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698