|
[turbofan] Remember types for deoptimization during simplified lowering.
With this change, we remember the types of frame state inputs (in a new
operator, called TypedStateValues). Instead of inferring the value types
when building translations, we used the recorded types.
The original approach was not reliable because the passes after
simplified lowering can change node types, and this in turn confuses
the translation builder.
BUG= chromium:468727
LOG=n
R=bmeurer@chromium.org
Committed: https://crrev.com/b7dc9c580a274c29622a7d7dcaf047a677c2e47d
Cr-Commit-Position: refs/heads/master@{#27310}
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+164 lines, -210 lines) |
Patch |
|
M |
src/compiler/code-generator.cc
|
View
|
|
3 chunks |
+12 lines, -6 lines |
0 comments
|
Download
|
|
M |
src/compiler/common-operator.h
|
View
|
1
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
src/compiler/common-operator.cc
|
View
|
1
|
1 chunk |
+9 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/compiler/instruction-selector.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
src/compiler/instruction-selector.cc
|
View
|
|
4 chunks |
+16 lines, -156 lines |
0 comments
|
Download
|
|
M |
src/compiler/liveness-analyzer.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/compiler/opcodes.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
src/compiler/simplified-lowering.cc
|
View
|
|
2 chunks |
+20 lines, -4 lines |
0 comments
|
Download
|
|
M |
src/compiler/state-values-utils.h
|
View
|
|
2 chunks |
+8 lines, -1 line |
0 comments
|
Download
|
|
M |
src/compiler/state-values-utils.cc
|
View
|
1
|
5 chunks |
+23 lines, -4 lines |
0 comments
|
Download
|
|
M |
src/compiler/typer.cc
|
View
|
|
1 chunk |
+5 lines, -0 lines |
0 comments
|
Download
|
|
M |
src/compiler/verifier.cc
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
test/cctest/compiler/test-codegen-deopt.cc
|
View
|
|
4 chunks |
+13 lines, -7 lines |
0 comments
|
Download
|
|
A + |
test/mjsunit/compiler/regress-468727.js
|
View
|
|
1 chunk |
+8 lines, -2 lines |
0 comments
|
Download
|
|
M |
test/unittests/compiler/instruction-selector-unittest.cc
|
View
|
|
4 chunks |
+32 lines, -14 lines |
0 comments
|
Download
|
|
M |
test/unittests/compiler/liveness-analyzer-unittest.cc
|
View
|
|
2 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
test/unittests/compiler/state-values-utils-unittest.cc
|
View
|
|
4 chunks |
+7 lines, -7 lines |
0 comments
|
Download
|
Total messages: 6 (2 generated)
|