Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: test/unittests/compiler/liveness-analyzer-unittest.cc

Issue 1015423002: [turbofan] Remember types for deoptimization during simplified lowering. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address review comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/compiler/liveness-analyzer-unittest.cc
diff --git a/test/unittests/compiler/liveness-analyzer-unittest.cc b/test/unittests/compiler/liveness-analyzer-unittest.cc
index b59c71aeb923c23501af86e82597b92c3109f067..f7d0db354d3c5299554e242b77c87e0a3bb55f69 100644
--- a/test/unittests/compiler/liveness-analyzer-unittest.cc
+++ b/test/unittests/compiler/liveness-analyzer-unittest.cc
@@ -115,15 +115,15 @@ class LivenessAnalysisTest : public GraphTest {
return false;
}
int i = 0;
- for (Node* value : locals) {
+ for (StateValuesAccess::TypedNode value : locals) {
if (liveness_[i] == 'L') {
StringMatchResultListener value_listener;
- if (value == replacement_) {
- *listener << "whose local #" << i << " was " << value->opcode()
+ if (value.node == replacement_) {
+ *listener << "whose local #" << i << " was " << value.node->opcode()
<< " but should have been 'undefined'";
return false;
} else if (!IsInt32Constant(first_const + i)
- .MatchAndExplain(value, &value_listener)) {
+ .MatchAndExplain(value.node, &value_listener)) {
*listener << "whose local #" << i << " does not match";
if (value_listener.str() != "") {
*listener << ", " << value_listener.str();
@@ -131,8 +131,8 @@ class LivenessAnalysisTest : public GraphTest {
return false;
}
} else if (liveness_[i] == '.') {
- if (value != replacement_) {
- *listener << "whose local #" << i << " is " << value
+ if (value.node != replacement_) {
+ *listener << "whose local #" << i << " is " << value.node
<< " but should have been " << replacement_
<< " (undefined)";
return false;
« no previous file with comments | « test/unittests/compiler/instruction-selector-unittest.cc ('k') | test/unittests/compiler/state-values-utils-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698