Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1015223002: Remove recent changes to use temp fbo to do stencil clears. (Closed)

Created:
5 years, 9 months ago by egdaniel
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove recent changes to use temp fbo to do stencil clears. In order to implement these stencil clears we had to use a work around where we would bind a color buffer renderbuffer to the fbo before clearing the stencil buffer. However this workaround seems to cause the win 7 hd2000 machines to all crash on some memory access issue. For now we will comment on the change and go back to the old world BUG=skia: Committed: https://skia.googlesource.com/skia/+/df60355438b22efd1e18608c32aa2144dde59aea

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M src/gpu/GrGpu.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
egdaniel
5 years, 9 months ago (2015-03-18 19:37:33 UTC) #2
robertphillips
lgtm :(
5 years, 9 months ago (2015-03-18 19:53:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1015223002/40001
5 years, 9 months ago (2015-03-18 20:04:16 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/df60355438b22efd1e18608c32aa2144dde59aea
5 years, 9 months ago (2015-03-18 20:26:21 UTC) #7
brian1
On 2015/03/18 20:26:21, I haz the power (commit-bot) wrote: > Committed patchset #3 (id:40001) as ...
5 years, 9 months ago (2015-03-19 15:16:03 UTC) #8
egdaniel
On 2015/03/19 15:16:03, brian1 wrote: > On 2015/03/18 20:26:21, I haz the power (commit-bot) wrote: ...
5 years, 9 months ago (2015-03-19 15:47:53 UTC) #9
robertphillips
5 years, 9 months ago (2015-03-19 16:04:31 UTC) #10
Message was sent while issue was closed.
It also looks like this patch didn't remedy the blurrects issue.

Powered by Google App Engine
This is Rietveld 408576698