Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 1014573010: Get rid of postToElement argument for accessibility notifications. (Closed)

Created:
5 years, 9 months ago by dmazzoni
Modified:
5 years, 8 months ago
CC:
blink-reviews, nektarios, dmazzoni, je_julie(Not used), aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@postnotification_1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Get rid of postToElement argument for accessibility notifications. It's a confusing argument because it's "true" 90% of the time. This changes the four cases where "false" was passed to take care of mapping to the "observable" object explicitly. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192725

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 4

Patch Set 3 : Reuse more code #

Patch Set 4 : Rebaseline test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -87 lines) Patch
M LayoutTests/accessibility/contenteditable-notifications.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/accessibility/contenteditable-notifications-expected.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXLayoutObject.h View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 1 2 5 chunks +3 lines, -32 lines 0 comments Download
M Source/modules/accessibility/AXMenuList.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXMenuListPopup.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 1 6 chunks +8 lines, -8 lines 0 comments Download
M Source/modules/accessibility/AXObject.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/accessibility/AXObjectCacheImpl.cpp View 1 2 9 chunks +30 lines, -28 lines 0 comments Download
M Source/modules/accessibility/AXTableRow.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/accessibility/AXTableRow.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
dmazzoni
Depends on: https://codereview.chromium.org/1032183003/
5 years, 9 months ago (2015-03-25 22:03:31 UTC) #2
je_julie(Not used)
lgtm https://codereview.chromium.org/1014573010/diff/20001/Source/modules/accessibility/AXObjectCacheImpl.cpp File Source/modules/accessibility/AXObjectCacheImpl.cpp (right): https://codereview.chromium.org/1014573010/diff/20001/Source/modules/accessibility/AXObjectCacheImpl.cpp#newcode754 Source/modules/accessibility/AXObjectCacheImpl.cpp:754: obj = obj->parentObject(); How about adding a helper ...
5 years, 9 months ago (2015-03-27 09:37:21 UTC) #3
dmazzoni
https://codereview.chromium.org/1014573010/diff/20001/Source/modules/accessibility/AXObjectCacheImpl.cpp File Source/modules/accessibility/AXObjectCacheImpl.cpp (right): https://codereview.chromium.org/1014573010/diff/20001/Source/modules/accessibility/AXObjectCacheImpl.cpp#newcode754 Source/modules/accessibility/AXObjectCacheImpl.cpp:754: obj = obj->parentObject(); On 2015/03/27 09:37:21, je_julie wrote: > ...
5 years, 9 months ago (2015-03-27 18:31:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014573010/40001
5 years, 9 months ago (2015-03-27 18:32:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/54695)
5 years, 9 months ago (2015-03-27 22:04:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014573010/60001
5 years, 9 months ago (2015-03-29 07:31:19 UTC) #12
commit-bot: I haz the power
5 years, 8 months ago (2015-03-29 11:24:11 UTC) #13
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192725

Powered by Google App Engine
This is Rietveld 408576698