Source/modules/accessibility/AXMenuList.cpp - Issue 1014573010: Get rid of postToElement argument for accessibility notifications.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/accessibility/AXMenuList.cpp

Issue 1014573010: Get rid of postToElement argument for accessibility notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@postnotification_1

Patch Set: Rebaseline test Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/modules/accessibility/AXLayoutObject.cpp ('k') | Source/modules/accessibility/AXMenuListPopup.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.	2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 109 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
120 if (!childObjects.isEmpty()) {	120 if (!childObjects.isEmpty()) {

121 ASSERT(childObjects.size() == 1);	121 ASSERT(childObjects.size() == 1);

122 ASSERT(childObjects[0]->isMenuListPopup());	122 ASSERT(childObjects[0]->isMenuListPopup());

123	123

124 if (childObjects[0]->isMenuListPopup()) {	124 if (childObjects[0]->isMenuListPopup()) {

125 if (AXMenuListPopup* popup = toAXMenuListPopup(childObjects[0].get() ))	125 if (AXMenuListPopup* popup = toAXMenuListPopup(childObjects[0].get() ))

126 popup->didUpdateActiveOption(optionIndex);	126 popup->didUpdateActiveOption(optionIndex);

127 }	127 }

128 }	128 }

129	129

130 cache->postNotification(this, AXObjectCacheImpl::AXMenuListValueChanged, tru e);	130 cache->postNotification(this, AXObjectCacheImpl::AXMenuListValueChanged);

131 }	131 }

132	132

133 } // namespace blink	133 } // namespace blink

OLD	NEW