Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Side by Side Diff: Source/modules/accessibility/AXTableRow.cpp

Issue 1014573010: Get rid of postToElement argument for accessibility notifications. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@postnotification_1
Patch Set: Rebaseline test Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/accessibility/AXTableRow.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
65 65
66 bool AXTableRow::isTableRow() const 66 bool AXTableRow::isTableRow() const
67 { 67 {
68 AXObject* table = parentTable(); 68 AXObject* table = parentTable();
69 if (!table || !table->isAXTable()) 69 if (!table || !table->isAXTable())
70 return false; 70 return false;
71 71
72 return true; 72 return true;
73 } 73 }
74 74
75 AXObject* AXTableRow::observableObject() const
76 {
77 // This allows the table to be the one who sends notifications about tables.
78 return parentTable();
79 }
80
81 bool AXTableRow::computeAccessibilityIsIgnored() const 75 bool AXTableRow::computeAccessibilityIsIgnored() const
82 { 76 {
83 AXObjectInclusion decision = defaultObjectInclusion(); 77 AXObjectInclusion decision = defaultObjectInclusion();
84 if (decision == IncludeObject) 78 if (decision == IncludeObject)
85 return false; 79 return false;
86 if (decision == IgnoreObject) 80 if (decision == IgnoreObject)
87 return true; 81 return true;
88 82
89 if (!isTableRow()) 83 if (!isTableRow())
90 return AXLayoutObject::computeAccessibilityIsIgnored(); 84 return AXLayoutObject::computeAccessibilityIsIgnored();
(...skipping 28 matching lines...) Expand all
119 for (const auto& cell : children()) { 113 for (const auto& cell : children()) {
120 if (!cell->isTableCell()) 114 if (!cell->isTableCell())
121 continue; 115 continue;
122 116
123 if (toAXTableCell(cell.get())->scanToDecideHeaderRole() == RowHeaderRole ) 117 if (toAXTableCell(cell.get())->scanToDecideHeaderRole() == RowHeaderRole )
124 headers.append(cell); 118 headers.append(cell);
125 } 119 }
126 } 120 }
127 121
128 } // namespace blink 122 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/accessibility/AXTableRow.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698