Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 1014573006: Give names to all WebRTC tests, temporarily disable audio codec tests. (Closed)

Created:
5 years, 9 months ago by phoglund_chromium
Modified:
5 years, 9 months ago
Reviewers:
qyearsley
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Give names to all WebRTC tests, temporarily disable audio codec tests. I found out I can give names to the test cases, which should make the graphs a lot easier to read. Also disabling some tests that currently don't produce useful data. BUG=468732 Committed: https://crrev.com/0807f9b84b7f315224d2b920546df1969f8c1cd9 Cr-Commit-Position: refs/heads/master@{#321544}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M tools/perf/page_sets/webrtc_cases.py View 10 chunks +18 lines, -10 lines 2 comments Download

Messages

Total messages: 10 (2 generated)
phoglund_chromium
If you're uncomfortable reviewing this, let me know if there's anyone else I should add ...
5 years, 9 months ago (2015-03-19 12:59:41 UTC) #2
qyearsley
On 2015/03/19 12:59:41, phoglund wrote: > If you're uncomfortable reviewing this, let me know if ...
5 years, 9 months ago (2015-03-20 01:04:02 UTC) #3
phoglund_chromium
On 2015/03/20 01:04:02, qyearsley wrote: > On 2015/03/19 12:59:41, phoglund wrote: > > If you're ...
5 years, 9 months ago (2015-03-20 09:26:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014573006/1
5 years, 9 months ago (2015-03-20 09:26:48 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 10:33:48 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0807f9b84b7f315224d2b920546df1969f8c1cd9 Cr-Commit-Position: refs/heads/master@{#321544}
5 years, 9 months ago (2015-03-20 10:34:34 UTC) #8
qyearsley
Oops, I forgot to actually publish my inline comments before making the comment before. (Well, ...
5 years, 9 months ago (2015-03-20 16:37:28 UTC) #9
phoglund_chromium
5 years, 9 months ago (2015-03-23 07:22:15 UTC) #10
Message was sent while issue was closed.
Ah. Yeah in retrospect it looked weird that you mentioned nits, but there
weren't any. I've fixed those now and they'll show up in my next patch.

Powered by Google App Engine
This is Rietveld 408576698