Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: tools/perf/page_sets/webrtc_cases.py

Issue 1014573006: Give names to all WebRTC tests, temporarily disable audio codec tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/webrtc_cases.py
diff --git a/tools/perf/page_sets/webrtc_cases.py b/tools/perf/page_sets/webrtc_cases.py
index 16918ebeb18a022fe0f3dfda62cdf8af5ef77981..8d1f82de3bbb9b7c7a5f47052137b949e16e76e7 100644
--- a/tools/perf/page_sets/webrtc_cases.py
+++ b/tools/perf/page_sets/webrtc_cases.py
@@ -12,8 +12,9 @@ WEBRTC_GITHUB_SAMPLES_URL = 'http://webrtc.github.io/samples/src/content/'
class WebrtcCasesPage(page_module.Page):
- def __init__(self, url, page_set):
- super(WebrtcCasesPage, self).__init__(url=url, page_set=page_set)
+ def __init__(self, url, page_set, name):
+ super(WebrtcCasesPage, self).__init__(
+ url=url, page_set=page_set, name=name)
with open(os.path.join(os.path.dirname(__file__),
'webrtc_track_peerconnections.js')) as javascript:
@@ -27,7 +28,8 @@ class Page1(WebrtcCasesPage):
def __init__(self, page_set):
super(Page1, self).__init__(
url=WEBRTC_GITHUB_SAMPLES_URL + 'getusermedia/gum/',
- page_set=page_set)
+ name="vga_local_stream_10s",
qyearsley 2015/03/20 16:37:28 Optional: Use single quotes for more consistency w
+ page_set=page_set)
def RunPageInteractions(self, action_runner):
action_runner.Wait(10)
@@ -40,6 +42,7 @@ class Page2(WebrtcCasesPage):
def __init__(self, page_set):
super(Page2, self).__init__(
url=WEBRTC_GITHUB_SAMPLES_URL + 'peerconnection/pc1/',
+ name="vga_call_10s",
page_set=page_set)
def RunPageInteractions(self, action_runner):
@@ -57,6 +60,7 @@ class Page3(WebrtcCasesPage):
def __init__(self, page_set):
super(Page3, self).__init__(
url=WEBRTC_GITHUB_SAMPLES_URL + 'getusermedia/resolution/',
+ name="hd_local_stream_10s",
page_set=page_set)
def RunPageInteractions(self, action_runner):
@@ -71,6 +75,7 @@ class Page4(WebrtcCasesPage):
def __init__(self, page_set):
super(Page4, self).__init__(
url=WEBRTC_GITHUB_SAMPLES_URL + 'peerconnection/audio/?codec=OPUS',
+ name="audio_call_opus_10s",
page_set=page_set)
def RunPageInteractions(self, action_runner):
@@ -86,6 +91,7 @@ class Page5(WebrtcCasesPage):
def __init__(self, page_set):
super(Page5, self).__init__(
url=WEBRTC_GITHUB_SAMPLES_URL + 'peerconnection/audio/?codec=G722',
+ name="audio_call_g722_10s",
page_set=page_set)
def RunPageInteractions(self, action_runner):
@@ -101,6 +107,7 @@ class Page6(WebrtcCasesPage):
def __init__(self, page_set):
super(Page6, self).__init__(
url=WEBRTC_GITHUB_SAMPLES_URL + 'peerconnection/audio/?codec=PCMU',
+ name="audio_call_pcmu_10s",
page_set=page_set)
def RunPageInteractions(self, action_runner):
@@ -116,6 +123,7 @@ class Page7(WebrtcCasesPage):
def __init__(self, page_set):
super(Page7, self).__init__(
url=WEBRTC_GITHUB_SAMPLES_URL + 'peerconnection/audio/?codec=ISAC_16K',
+ name="audio_call_isac16k_10s",
page_set=page_set)
def RunPageInteractions(self, action_runner):
@@ -131,6 +139,7 @@ class Page8(WebrtcCasesPage):
def __init__(self, page_set):
super(Page8, self).__init__(
url=WEBRTC_GITHUB_SAMPLES_URL + 'peerconnection/constraints/',
+ name="1080p_call_45s",
page_set=page_set)
def RunPageInteractions(self, action_runner):
@@ -155,11 +164,10 @@ class WebrtcCasesPageSet(page_set_module.PageSet):
self.AddUserStory(Page1(self))
self.AddUserStory(Page2(self))
self.AddUserStory(Page3(self))
- self.AddUserStory(Page1(self))
- self.AddUserStory(Page2(self))
- self.AddUserStory(Page3(self))
- self.AddUserStory(Page4(self))
- self.AddUserStory(Page5(self))
- self.AddUserStory(Page6(self))
- self.AddUserStory(Page7(self))
+ # Disabled until we can implement http://crbug.com/468732. We can get
+ # data out from the tests, but it's not very useful yet.
+ #self.AddUserStory(Page4(self))
+ #self.AddUserStory(Page5(self))
+ #self.AddUserStory(Page6(self))
+ #self.AddUserStory(Page7(self))
qyearsley 2015/03/20 16:37:28 You could also I think that deleting these lines a
self.AddUserStory(Page8(self))
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698