Give names to all WebRTC tests, temporarily disable audio codec tests.

tools/perf/page_sets/webrtc_cases.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import os
 
 from telemetry.page import page as page_module
 from telemetry.page import page_set as page_set_module
 
 
 WEBRTC_GITHUB_SAMPLES_URL = 'http://webrtc.github.io/samples/src/content/'
 
 
 class WebrtcCasesPage(page_module.Page):
 
-  def __init__(self, url, page_set):
-    super(WebrtcCasesPage, self).__init__(url=url, page_set=page_set)
+  def __init__(self, url, page_set, name):
+    super(WebrtcCasesPage, self).__init__(
+        url=url, page_set=page_set, name=name)
 
     with open(os.path.join(os.path.dirname(__file__),
                            'webrtc_track_peerconnections.js')) as javascript:
       self.script_to_evaluate_on_commit = javascript.read()
 
 
 class Page1(WebrtcCasesPage):
 
   """ Why: Acquires a vga local stream. """
 
   def __init__(self, page_set):
     super(Page1, self).__init__(
         url=WEBRTC_GITHUB_SAMPLES_URL + 'getusermedia/gum/',
-      page_set=page_set)
+        name="vga_local_stream_10s",

[qyearsley, 2015/03/20 16:37:28]

Optional: Use single quotes for more consistency with other strings in this
file.

I actually believed that the style guide explicitly said to use single quotes,
but Now that I look at PEP8 and google style guide, neither of these forbid
double quotes for strings, but they both suggest keeping it consistent.

+        page_set=page_set)
 
   def RunPageInteractions(self, action_runner):
     action_runner.Wait(10)
 
 
 class Page2(WebrtcCasesPage):
 
   """ Why: Sets up a local WebRTC call. """
 
   def __init__(self, page_set):
     super(Page2, self).__init__(
       url=WEBRTC_GITHUB_SAMPLES_URL + 'peerconnection/pc1/',
+      name="vga_call_10s",
       page_set=page_set)
 
   def RunPageInteractions(self, action_runner):
     action_runner.ClickElement('button[id="startButton"]')
     action_runner.Wait(2)
     action_runner.ClickElement('button[id="callButton"]')
     action_runner.Wait(10)
     action_runner.ClickElement('button[id="hangupButton"]')
 
 
 class Page3(WebrtcCasesPage):
 
   """ Why: Acquires a high definition local stream. """
 
   def __init__(self, page_set):
     super(Page3, self).__init__(
       url=WEBRTC_GITHUB_SAMPLES_URL + 'getusermedia/resolution/',
+      name="hd_local_stream_10s",
       page_set=page_set)
 
   def RunPageInteractions(self, action_runner):
     action_runner.ClickElement('button[id="hd"]')
     action_runner.Wait(10)
 
 
 class Page4(WebrtcCasesPage):
 
   """ Why: Sets up a WebRTC audio call with Opus. """
 
   def __init__(self, page_set):
     super(Page4, self).__init__(
       url=WEBRTC_GITHUB_SAMPLES_URL + 'peerconnection/audio/?codec=OPUS',
+      name="audio_call_opus_10s",
       page_set=page_set)
 
   def RunPageInteractions(self, action_runner):
     action_runner.ExecuteJavaScript('codecSelector.value="OPUS";')
     action_runner.ClickElement('button[id="callButton"]')
     action_runner.Wait(10)
 
 
 class Page5(WebrtcCasesPage):
 
   """ Why: Sets up a WebRTC audio call with G722. """
 
   def __init__(self, page_set):
     super(Page5, self).__init__(
       url=WEBRTC_GITHUB_SAMPLES_URL + 'peerconnection/audio/?codec=G722',
+      name="audio_call_g722_10s",
       page_set=page_set)
 
   def RunPageInteractions(self, action_runner):
     action_runner.ExecuteJavaScript('codecSelector.value="G722";')
     action_runner.ClickElement('button[id="callButton"]')
     action_runner.Wait(10)
 
 
 class Page6(WebrtcCasesPage):
 
   """ Why: Sets up a WebRTC audio call with PCMU. """
 
   def __init__(self, page_set):
     super(Page6, self).__init__(
       url=WEBRTC_GITHUB_SAMPLES_URL + 'peerconnection/audio/?codec=PCMU',
+      name="audio_call_pcmu_10s",
       page_set=page_set)
 
   def RunPageInteractions(self, action_runner):
     action_runner.ExecuteJavaScript('codecSelector.value="PCMU";')
     action_runner.ClickElement('button[id="callButton"]')
     action_runner.Wait(10)
 
 
 class Page7(WebrtcCasesPage):
 
   """ Why: Sets up a WebRTC audio call with iSAC 16K. """
 
   def __init__(self, page_set):
     super(Page7, self).__init__(
       url=WEBRTC_GITHUB_SAMPLES_URL + 'peerconnection/audio/?codec=ISAC_16K',
+      name="audio_call_isac16k_10s",
       page_set=page_set)
 
   def RunPageInteractions(self, action_runner):
     action_runner.ExecuteJavaScript('codecSelector.value="ISAC/16000";')
     action_runner.ClickElement('button[id="callButton"]')
     action_runner.Wait(10)
 
 
 class Page8(WebrtcCasesPage):
 
   """ Why: Sets up a WebRTC 1080p call for 45 seconds. """
 
   def __init__(self, page_set):
     super(Page8, self).__init__(
         url=WEBRTC_GITHUB_SAMPLES_URL + 'peerconnection/constraints/',
+        name="1080p_call_45s",
         page_set=page_set)
 
   def RunPageInteractions(self, action_runner):
     action_runner.ExecuteJavaScript('minWidthInput.value = 1920')
     action_runner.ExecuteJavaScript('maxWidthInput.value = 1920')
     action_runner.ExecuteJavaScript('minHeightInput.value = 1080')
     action_runner.ExecuteJavaScript('maxHeightInput.value = 1080')
     action_runner.ClickElement('button[id="getMedia"]')
     action_runner.Wait(2)
     action_runner.ClickElement('button[id="connect"]')
     action_runner.Wait(45)
 
 class WebrtcCasesPageSet(page_set_module.PageSet):
 
   """ WebRTC tests for Real-time audio and video communication. """
 
   def __init__(self):
     super(WebrtcCasesPageSet, self).__init__(
       archive_data_file='data/webrtc_cases.json',
       bucket=page_set_module.PUBLIC_BUCKET)
 
     self.AddUserStory(Page1(self))
     self.AddUserStory(Page2(self))
     self.AddUserStory(Page3(self))
-    self.AddUserStory(Page1(self))
-    self.AddUserStory(Page2(self))
-    self.AddUserStory(Page3(self))
-    self.AddUserStory(Page4(self))
-    self.AddUserStory(Page5(self))
-    self.AddUserStory(Page6(self))
-    self.AddUserStory(Page7(self))
+    # Disabled until we can implement http://crbug.com/468732. We can get
+    # data out from the tests, but it's not very useful yet.
+    #self.AddUserStory(Page4(self))
+    #self.AddUserStory(Page5(self))
+    #self.AddUserStory(Page6(self))
+    #self.AddUserStory(Page7(self))

[qyearsley, 2015/03/20 16:37:28]

You could also I think that deleting these lines and add a TODO rather than
commenting them out.

     self.AddUserStory(Page8(self))