Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1014433002: Land Recent QUIC Changes until 03/09/2015. (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ian Swett, rjshade, alyssar
Base URL:
https://chromium.googlesource.com/chromium/src.git@replaces_Perspective_enun_88006458
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Land Recent QUIC Changes until 03/09/2015. Add a new method to the QuicUnackedPacketMap to stop retransmitting stream frames for a given stream. Will be wired up so that data will not be restransmitted for a stream that is reset. No behavior changes in this CL. Merge internal change: 88162937 https://codereview.chromium.org/1008593005/ Create a TcpCubicSender in QUIC that tracks the congestion window in bytes, instead of packets. Merge internal change: 88159377 https://codereview.chromium.org/1009023002/ Remove FLAGS_quic_enable_pacing flag now that pacing is on by default globally. Merge internal change: 88152071 https://codereview.chromium.org/1006113002/ Plumb through sent/received CachedNetworkParamaters to populate TransportConnectionStats. Merge internal change: 88144945 https://codereview.chromium.org/1010463002/ QUIC - Initialize QuicConfig's negotiated_value_ to 0. IMO, it is not necessary to initialize it (could calm some compiler warnings??). Minor change to fix compiler warnings in chromium. Merge internal change: 88129037 https://codereview.chromium.org/1008473003/ Create a QUIC connection option to set the min CWND to 1 packet instead of 2 in TcpCubicSender. Merge internal change: 88045604 https://codereview.chromium.org/1001933003/ R=rch@chromium.org Committed: https://crrev.com/73e25c1b46d6da0e1a3f49f72889975129ea2d2f Cr-Commit-Position: refs/heads/master@{#320699}

Patch Set 1 #

Patch Set 2 : Rebase - added NET_EXPORT_PRIVATE to fix compiler error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -382 lines) Patch
M net/net.gypi View 4 chunks +6 lines, -0 lines 0 comments Download
A + net/quic/congestion_control/cubic_bytes.h View 4 chunks +24 lines, -23 lines 0 comments Download
A + net/quic/congestion_control/cubic_bytes.cc View 10 chunks +31 lines, -38 lines 0 comments Download
A net/quic/congestion_control/cubic_bytes_test.cc View 1 chunk +157 lines, -0 lines 0 comments Download
A + net/quic/congestion_control/tcp_cubic_bytes_sender.h View 5 chunks +25 lines, -27 lines 0 comments Download
A + net/quic/congestion_control/tcp_cubic_bytes_sender.cc View 17 chunks +75 lines, -76 lines 0 comments Download
A + net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc View 29 chunks +101 lines, -121 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.h View 2 chunks +4 lines, -2 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 5 chunks +11 lines, -5 lines 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender_test.cc View 2 chunks +14 lines, -1 line 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_config.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_connection.h View 2 chunks +12 lines, -0 lines 0 comments Download
M net/quic/quic_connection.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/quic_protocol.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_protocol.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M net/quic/quic_server_session.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_unacked_packet_map.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M net/quic/quic_unacked_packet_map_test.cc View 2 chunks +70 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 8 chunks +18 lines, -62 lines 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ramant (doing other things)
5 years, 9 months ago (2015-03-16 00:19:28 UTC) #1
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-16 03:16:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014433002/20001
5 years, 9 months ago (2015-03-16 03:27:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1014433002/20001
5 years, 9 months ago (2015-03-16 06:12:19 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 06:12:54 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 06:13:33 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/73e25c1b46d6da0e1a3f49f72889975129ea2d2f
Cr-Commit-Position: refs/heads/master@{#320699}

Powered by Google App Engine
This is Rietveld 408576698