Prevent creating background pages for non-incognito profile in Guest mode

Prevent creating background pages for non-incognito profile in Guest mode

BUG=329498
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242271

[Dmitry Polukhin, 2013-12-20 00:56:08]

Mike, please take a look. See crbug.com/329498 for more context about this
issue.

[Dmitry Polukhin, 2013-12-20 01:42:38]

PTAL

rlp@ for OWNER review in chrome/browser/profiles/
miket@ for OWNER review in extensions code

[Dmitry Polukhin, 2013-12-20 16:46:17]

fixed missprint

[miket_OOO, 2013-12-20 18:59:01]

LGTM but please consider comment first.

https://codereview.chromium.org/101413011/diff/360001/chrome/browser/profiles...
File chrome/browser/profiles/profile_manager.cc (right):

https://codereview.chromium.org/101413011/diff/360001/chrome/browser/profiles...
chrome/browser/profiles/profile_manager.cc:1106:
command_line.HasSwitch(chromeos::switches::kLoginProfile)))) {
This code is getting pretty tricky. What do you think about extending
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...
to test and protect the new logic?

[Dmitry Polukhin, 2013-12-20 21:55:53]

Rachel, please take a look as chrome/browser/profiles OWNER.

https://codereview.chromium.org/101413011/diff/360001/chrome/browser/profiles...
File chrome/browser/profiles/profile_manager.cc (right):

https://codereview.chromium.org/101413011/diff/360001/chrome/browser/profiles...
chrome/browser/profiles/profile_manager.cc:1106:
command_line.HasSwitch(chromeos::switches::kLoginProfile)))) {
On 2013/12/20 18:59:02, miket wrote:
> This code is getting pretty tricky. What do you think about extending
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...
> to test and protect the new logic?

It looks like creating test is not easy task because ProfileManagerTest so
deeply mock and stub things that there is no corresponding incognito profile for
normal profile. I'll add this test in follow up CL before closing issue.

[Dmitry Polukhin, 2013-12-20 22:14:02]

+ Dave for OWNER review in chrome/browser/profiles/

[DaveMoore, 2013-12-20 22:30:10]

lgtm

[Dmitry Polukhin, 2013-12-20 22:32:52]

Thanks!

FYI, follow up CL with test is here https://codereview.chromium.org/115073003/
and it is longer than whole this CL

[rpetterson, 2013-12-20 22:33:29]

lgtm

[commit-bot: I haz the power, 2013-12-20 22:34:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/101413011/360001

[commit-bot: I haz the power, 2013-12-21 01:07:37]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-21 01:14:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/101413011/360001

[commit-bot: I haz the power, 2013-12-21 04:23:19]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-12-21 06:41:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/101413011/360001

[commit-bot: I haz the power, 2013-12-21 07:20:25]

Change committed as 242271