Prevent creating background pages for non-incognito profile in Guest mode

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 1082 matching lines @@
 void ProfileManager::SetGuestProfilePrefs(Profile* profile) {
   IncognitoModePrefs::SetAvailability(profile->GetPrefs(),
                                       IncognitoModePrefs::FORCED);
   profile->GetPrefs()->SetBoolean(prefs::kShowBookmarkBar, false);
 }
 
 bool ProfileManager::ShouldGoOffTheRecord(Profile* profile) {
   bool go_off_the_record = false;
 #if defined(OS_CHROMEOS)
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
-  if (profile->GetPath().BaseName().value() == chrome::kInitialProfile &&
-      (!command_line.HasSwitch(switches::kTestType) ||
-       command_line.HasSwitch(chromeos::switches::kLoginProfile))) {
+  if (command_line.HasSwitch(chromeos::switches::kGuestSession) ||
+      (profile->GetPath().BaseName().value() == chrome::kInitialProfile &&
+       (!command_line.HasSwitch(switches::kTestType) ||
+       command_line.HasSwitch(chromeos::switches::kLoginProfile)))) {

[miket_OOO, 2013/12/20 18:59:02]

This code is getting pretty tricky. What do you think about extending
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/pro...
to test and protect the new logic?

[Dmitry Polukhin, 2013/12/20 21:55:54]

It looks like creating test is not easy task because ProfileManagerTest so
deeply mock and stub things that there is no corresponding incognito profile for
normal profile. I'll add this test in follow up CL before closing issue.

     go_off_the_record = true;
   }
 #endif
   return go_off_the_record;
 }
 
 void ProfileManager::ScheduleProfileForDeletion(
     const base::FilePath& profile_dir,
     const CreateCallback& callback) {
   DCHECK(profiles::IsMultipleProfilesEnabled());
@@ skipping 163 matching lines @@
 ProfileManager::ProfileInfo::ProfileInfo(
     Profile* profile,
     bool created)
     : profile(profile),
       created(created) {
 }
 
 ProfileManager::ProfileInfo::~ProfileInfo() {
   ProfileDestroyer::DestroyProfileWhenAppropriate(profile.release());
 }