Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1554)

Unified Diff: chrome/browser/extensions/chrome_extensions_browser_client.cc

Issue 101413011: Prevent creating background pages for non-incognito profile in Guest mode (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_extensions_browser_client.cc
diff --git a/chrome/browser/extensions/chrome_extensions_browser_client.cc b/chrome/browser/extensions/chrome_extensions_browser_client.cc
index 69b3a96e11a7ad6a42c69b50c0f4f93c17142572..f6b129246f6011c42ab595d6cccefca3204a14f1 100644
--- a/chrome/browser/extensions/chrome_extensions_browser_client.cc
+++ b/chrome/browser/extensions/chrome_extensions_browser_client.cc
@@ -18,6 +18,10 @@
#include "chrome/common/chrome_version_info.h"
#include "chrome/common/pref_names.h"
+#if defined(OS_CHROMEOS)
+#include "chromeos/chromeos_switches.h"
+#endif
+
namespace extensions {
ChromeExtensionsBrowserClient::ChromeExtensionsBrowserClient() {}
@@ -89,6 +93,21 @@ bool ChromeExtensionsBrowserClient::DeferLoadingBackgroundHosts(
#endif
}
+bool ChromeExtensionsBrowserClient::IsBackgroundPageAllowed(
+ content::BrowserContext* context) const {
+#if defined(OS_CHROMEOS)
+ // Returns true if current session is Chrome OS Guest mode session and current
+ // browser context is *not* off-the-record. Such context is artificial and
+ // background page shouldn't be created in it.
+ const CommandLine* command_line = CommandLine::ForCurrentProcess();
+ if (command_line->HasSwitch(chromeos::switches::kGuestSession) &&
+ !context->IsOffTheRecord()) {
+ return false;
+ }
+#endif
+ return true;
+}
+
bool ChromeExtensionsBrowserClient::DidVersionUpdate(
content::BrowserContext* context) {
Profile* profile = static_cast<Profile*>(context);

Powered by Google App Engine
This is Rietveld 408576698