extensions/browser/api/vpn_provider/vpn_service.h - Issue 1014053002: Provide warning message for setParameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/vpn_provider/vpn_service.h

Issue 1014053002: Provide warning message for setParameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Print only when there is a warning and fix unittest error Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/vpn_provider/vpn_service.h

diff --git a/extensions/browser/api/vpn_provider/vpn_service.h b/extensions/browser/api/vpn_provider/vpn_service.h

index 96bca6eb45d8ccda8db622bd5d69b338d70d3f07..25e93172aa837de0265630cd8c189e3e66da86d6 100644

--- a/extensions/browser/api/vpn_provider/vpn_service.h

+++ b/extensions/browser/api/vpn_provider/vpn_service.h

@@ -53,6 +53,7 @@ class VpnService : public KeyedService,

public extensions::ExtensionRegistryObserver {

public:

using SuccessCallback = base::Closure;

+ using StringCallback = base::Callback<void(const std::string& result)>;

using FailureCallback =

base::Callback<void(const std::string& error_name,

const std::string& error_message)>;

@@ -126,7 +127,7 @@ class VpnService : public KeyedService,

// Calls |success| or |failure| based on the outcome.

void SetParameters(const std::string& extension_id,

const base::DictionaryValue& parameters,

- const SuccessCallback& success,

+ const StringCallback& success,

const FailureCallback& failure);

// Sends an IP packet contained in |data| to the active VPN configuration