Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: extensions/browser/api/vpn_provider/vpn_provider_api.cc

Issue 1014053002: Provide warning message for setParameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Print only when there is a warning and fix unittest error Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/vpn_provider/vpn_provider_api.cc
diff --git a/extensions/browser/api/vpn_provider/vpn_provider_api.cc b/extensions/browser/api/vpn_provider/vpn_provider_api.cc
index 24b7f0e324eec2654196962cafbb96a4702889b1..f38a1e275153721f48958f5ee3811d1ff66c5458 100644
--- a/extensions/browser/api/vpn_provider/vpn_provider_api.cc
+++ b/extensions/browser/api/vpn_provider/vpn_provider_api.cc
@@ -155,6 +155,14 @@ void VpnThreadExtensionFunction::SignalCallCompletionSuccessWithId(
Respond(OneArgument(new base::StringValue(configuration_id)));
}
+void VpnThreadExtensionFunction::SignalCallCompletionSuccessWithWarning(
+ const std::string& warning) {
+ if (!warning.empty()) {
+ WriteToConsole(content::CONSOLE_MESSAGE_LEVEL_WARNING, warning);
+ }
+ Respond(NoArguments());
+}
+
void VpnThreadExtensionFunction::SignalCallCompletionFailure(
const std::string& error_name,
const std::string& error_message) {
@@ -249,7 +257,8 @@ ExtensionFunction::ResponseAction VpnProviderSetParametersFunction::Run() {
service->SetParameters(
extension_id(), parameter_value,
- base::Bind(&VpnProviderSetParametersFunction::SignalCallCompletionSuccess,
+ base::Bind(&VpnProviderSetParametersFunction::
+ SignalCallCompletionSuccessWithWarning,
this),
base::Bind(&VpnProviderNotifyConnectionStateChangedFunction::
SignalCallCompletionFailure,

Powered by Google App Engine
This is Rietveld 408576698