extensions/browser/api/vpn_provider/vpn_service.cc - Issue 1014053002: Provide warning message for setParameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/vpn_provider/vpn_service.cc

Issue 1014053002: Provide warning message for setParameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Print only when there is a warning and fix unittest error Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/vpn_provider/vpn_service.cc

diff --git a/extensions/browser/api/vpn_provider/vpn_service.cc b/extensions/browser/api/vpn_provider/vpn_service.cc

index f849f1f2a72bf38f137b9801901d59e917435a31..1e94b18fc73937a948ee328e69d538610abe8e27 100644

--- a/extensions/browser/api/vpn_provider/vpn_service.cc

+++ b/extensions/browser/api/vpn_provider/vpn_service.cc

@@ -376,7 +376,7 @@ void VpnService::DestroyConfiguration(const std::string& extension_id,

void VpnService::SetParameters(const std::string& extension_id,

const base::DictionaryValue& parameters,

- const SuccessCallback& success,

+ const StringCallback& success,

const FailureCallback& failure) {

if (!DoesActiveConfigurationExistAndIsAccessAuthorized(extension_id)) {

failure.Run(std::string(), std::string("Unauthorized access."));