extensions/browser/api/vpn_provider/vpn_provider_api.h - Issue 1014053002: Provide warning message for setParameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/vpn_provider/vpn_provider_api.h

Issue 1014053002: Provide warning message for setParameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Print only when there is a warning and fix unittest error Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/vpn_provider/vpn_provider_api.h

diff --git a/extensions/browser/api/vpn_provider/vpn_provider_api.h b/extensions/browser/api/vpn_provider/vpn_provider_api.h

index d0e7a32a8a0325232e07c5c9b894941293a985ae..3d3bb1deca195cb2ba16ab5fa4b43c846fe2063e 100644

--- a/extensions/browser/api/vpn_provider/vpn_provider_api.h

+++ b/extensions/browser/api/vpn_provider/vpn_provider_api.h

@@ -15,6 +15,7 @@ class VpnThreadExtensionFunction : public UIThreadExtensionFunction {

public:

void SignalCallCompletionSuccess();

void SignalCallCompletionSuccessWithId(const std::string& configuration_id);

+ void SignalCallCompletionSuccessWithWarning(const std::string& warning);

void SignalCallCompletionFailure(const std::string& error_name,

const std::string& error_message);